[
https://issues.apache.org/jira/browse/DATAFU-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13975286#comment-13975286
]
Matthew Hayes commented on DATAFU-34:
-------------------------------------
Can you open a review board?
Some comments:
BagToMap:
* In exec(), should we check that the key isn't already in the map and throw an
error if it is? Otherwise it could lead to unexpected behavior.
* Minor typos in sample code. dump statements should end in semicolon.
ContainKeys:
* I think this method name could be confusing. I was actually confused when I
looked at the example because I didn't realize at first the default was "any."
It may be clearer to have two methods: ContainsAllKeys and ContainsAnyKeys. An
abstract base class could have most of the implementation.
> Add some UDFS to handle map type
> --------------------------------
>
> Key: DATAFU-34
> URL: https://issues.apache.org/jira/browse/DATAFU-34
> Project: DataFu
> Issue Type: New Feature
> Reporter: jian wang
> Assignee: jian wang
> Attachments: 0001-add-some-UDFs-to-manipulate-map.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
