----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21306/#review42709 -----------------------------------------------------------
Nice job on the tests :) You're covering a lot of cases. I think this is getting pretty close to being ready. Just need to look into the issues raised below. datafu-pig/src/main/java/datafu/pig/maps/ContainAllKeys.java <https://reviews.apache.org/r/21306/#comment76522> I prefer the name ContainsAllKeys datafu-pig/src/main/java/datafu/pig/maps/ContainAnyKey.java <https://reviews.apache.org/r/21306/#comment76523> ContainsAnyKey datafu-pig/src/main/java/datafu/pig/maps/ContainKeys.java <https://reviews.apache.org/r/21306/#comment76530> rename to ContainsKeys to be consistent with proposed renames to other UDFs datafu-pig/src/main/java/datafu/pig/maps/MapToBag.java <https://reviews.apache.org/r/21306/#comment76567> I think the value type might actually be accessed like I have it below. Can you confirm this? Make sure a test case catches this if it's a problem. input.getField(0).schema.getField(1).type datafu-pig/src/main/java/datafu/pig/maps/PutToMap.java <https://reviews.apache.org/r/21306/#comment76573> Double check whether it should be: input.getField(0).schema.getField(1).type datafu-pig/src/test/java/datafu/test/pig/maps/MapTests.java <https://reviews.apache.org/r/21306/#comment76575> Use my CheckMap UDF to verify value is an int. Same goes for other tests that produce maps. datafu-pig/src/test/java/datafu/test/pig/maps/MapTests.java <https://reviews.apache.org/r/21306/#comment76595> these tuples have two fields but the bag only has val in the script - Matthew Hayes On May 11, 2014, 12:42 p.m., wang jian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21306/ > ----------------------------------------------------------- > > (Updated May 11, 2014, 12:42 p.m.) > > > Review request for DataFu. > > > Bugs: https://issues.apache.org/jira/browse/DATAFU-34 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/DATAFU-34 > > > Repository: datafu > > > Description > ------- > > Add UDFs to handle map type data. > > Unit tests done. > > One thing left over: validate the byte array output from map > > > Diffs > ----- > > datafu-pig/src/main/java/datafu/pig/maps/BagToMap.java PRE-CREATION > datafu-pig/src/main/java/datafu/pig/maps/ContainAllKeys.java PRE-CREATION > datafu-pig/src/main/java/datafu/pig/maps/ContainAnyKey.java PRE-CREATION > datafu-pig/src/main/java/datafu/pig/maps/ContainKeys.java PRE-CREATION > datafu-pig/src/main/java/datafu/pig/maps/MapToBag.java PRE-CREATION > datafu-pig/src/main/java/datafu/pig/maps/PutToMap.java PRE-CREATION > datafu-pig/src/test/java/datafu/test/pig/maps/MapTests.java PRE-CREATION > > Diff: https://reviews.apache.org/r/21306/diff/ > > > Testing > ------- > > ues > > > Thanks, > > wang jian > >
