-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21618/
-----------------------------------------------------------
(Updated May 19, 2014, 11:12 p.m.)
Review request for DataFu and Matthew Hayes.
Bugs: DATAFU-47
https://issues.apache.org/jira/browse/DATAFU-47
Repository: datafu
Description
-------
Accompanies DATAFU-47 https://issues.apache.org/jira/browse/DATAFU-47 -- make
sure to apply the patch from DATAFU-46 too first
Questions for reviewers:
* If we upgrade Guava, we'd get sip24 (a fast cryptographically secure hash),
crc32 and adler32 (occasionally useful checksums). I can put the update in as
another patch. Should we upgrade?
* This UDF provides the same hashes as MD5 and SHA udfs. Should those be
deprecated in favor of this? I can add the binhex functionality so that nothing
is lost.
* If there's a standard way to do the dependency injection of a fixed random
number generator for the tests please advise.
Diffs (updated)
-----
datafu-pig/src/main/java/datafu/pig/hash/Hasher.java PRE-CREATION
datafu-pig/src/test/java/datafu/test/pig/hash/HashTests.java 7ff8fb9
Diff: https://reviews.apache.org/r/21618/diff/
Testing
-------
./gradlew :datafu-pig:test -Dtest.single=HashTests
Thanks,
Philip (flip) Kromer
