[
https://issues.apache.org/jira/browse/DATAFU-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084829#comment-14084829
]
Jakob Homan commented on DATAFU-57:
-----------------------------------
Overall, looks good. One thing I notice is that running gradle -b
bootstrap.gradle clobbers the memory settings currently stored in gradlew:
{noformat}
# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to
pass JVM options to this script.
-DEFAULT_JVM_OPTS="-XX:MaxPermSize=512m"
+DEFAULT_JVM_OPTS=""
{noformat}
These can be persisted in gradle.properties instead:
{noformat}--- gradle.properties
+++ gradle.properties
@@ -17,3 +17,7 @@
group=org.apache.samza
version=0.7.0
scalaVersion=2.10
+
+org.gradle.jvmargs="-XX:MaxPermSize=512m"{noformat}
and won't be affected by future version updates. Otherwise +1.
> Source release build tasks
> --------------------------
>
> Key: DATAFU-57
> URL: https://issues.apache.org/jira/browse/DATAFU-57
> Project: DataFu
> Issue Type: Sub-task
> Reporter: Matthew Hayes
> Assignee: Matthew Hayes
> Fix For: 1.3.0
>
> Attachments: DATAFU-57-v2.patch, DATAFU-57.patch
>
>
> We need gradle build tasks for creating a source release. We can probably
> use code from SAMZA-283, which includes these tasks for Samza.
> The source release task should not include the gradle jar. We need a
> bootstrap task to download the wrapper.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
