[
https://issues.apache.org/jira/browse/DATAFU-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225809#comment-14225809
]
Matthew Hayes commented on DATAFU-80:
-------------------------------------
Thanks! Can you open a review board at https://reviews.apache.org/ so it is
easier to add comments? Please also add a unit test.
We should consider whether something like the following should work:
FILTER users BY IN(country, STRSPLIT('$list_A',','), STRSPLIT('$list_B',','))
The code you currently have will iterate through each of the values in the
tuples until it finds a match. I'm not sure if this is what we want to do.
What may make more sense is to only iterate through the values when a single
tuple is passed in. If multiple tuples are passed in then we assume that they
want to match against tuples, not the values within the tuples.
Also I noticed that your comment for the second patch is "Add support for java
1.6 compatibility" however you set it to 1.5 in the gradle file. Did you
intend to use 1.6?
> Enahnce InUDF to support tuple collection from String and Add Java
> Compatibility for DataFu-Pig
> -----------------------------------------------------------------------------------------------
>
> Key: DATAFU-80
> URL: https://issues.apache.org/jira/browse/DATAFU-80
> Project: DataFu
> Issue Type: Improvement
> Affects Versions: 1.3.0
> Environment: Mac OS X Yosemite
> Reporter: Yiqun Hu
> Priority: Minor
> Labels: features
> Fix For: 1.3.0
>
> Attachments: DATAFU-80.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> * Enahnce InUDF to support tuple collection from String
> In many of our application, we need the IN operator for FILTER to operation
> on a string representing multiple values e.g. 'AU,SG,HK' for a country list.
> So we need IN operation to support something like
> FILTER users BY IN(country, STRSPLIT('$country_list',','))
> where the value of $country_list is 'AU,SG,HK' passed as input parameter.
> I found this one is generally useful for many application. so send the minor
> enhancement about it.
> * JAVA Compatibility for DataFu-Pig
> Different JVM version can be used to build DataFu, but the generated jar
> without java compatibility support cannot run on the platform using different
> version of JVM. So add java compatibility suport in build.gradle.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
