> On Feb. 1, 2017, 7:46 a.m., Matthew Hayes wrote: > > datafu-pig/src/test/java/datafu/test/pig/PigTests.java, line 62 > > <https://reviews.apache.org/r/55110/diff/2/?file=1607015#file1607015line62> > > > > Instead of updating and restoring the user.dir I think it would be > > better to update methods like getFile that use it. You could derive the > > test file subdirectory from it without altering it. I think most of the > > tests are using this method ultimately to get a File to write data to. > > There are probably some other places to update too but I don't think there > > are too many.
Just noticed the previous discussion. Will think about it more. Maybe there isn't a better way. - Matthew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55110/#review163790 ----------------------------------------------------------- On Jan. 17, 2017, 9:52 p.m., Piyush Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55110/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2017, 9:52 p.m.) > > > Review request for DataFu and Matthew Hayes. > > > Repository: datafu > > > Description > ------- > > DATAFU-106: Test files are currently created in the subdirectory folder (e.g. > datafu-pig/input*). For better organization, they should be created in a > subdirectory. This also makes it easier to exclude them all with gitignore. > (issue: https://issues.apache.org/jira/browse/DATAFU-106) > > > Diffs > ----- > > datafu-pig/src/test/java/datafu/test/TestFilesSubdirTest.java PRE-CREATION > datafu-pig/src/test/java/datafu/test/pig/PigTests.java d1d6fcc > > Diff: https://reviews.apache.org/r/55110/diff/ > > > Testing > ------- > > unit tests passed. > > > Thanks, > > Piyush Sharma > >
