> On Aug. 3, 2017, 7:36 p.m., Matthew Hayes wrote: > > Hmm I'm not able to apply the patch. What command did you use to create it? > > > > ``` > > git am DATAFU-123-2.patch > > Patch format detection failed. > > ```
*git am DATAFU-123-2.patch* gives me the same result ... but *git apply* works cleanly. I'm at a different computer, so I can't see my bash history, but I'm pretty sure I used *git format-patch master --stdout > DATAFU-123.patch* I wonder if it's a line-endings os-specific issue - both my computers are running Ubuntu. - Eyal ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61378/#review182123 ----------------------------------------------------------- On Aug. 3, 2017, 3:43 p.m., Eyal Allweil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61378/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2017, 3:43 p.m.) > > > Review request for DataFu and Matthew Hayes. > > > Repository: datafu > > > Description > ------- > > DATAFU-123 Allow DataFu to include macros > > > Diffs > ----- > > datafu-pig/src/main/resources/datafu/count_macros.pig PRE-CREATION > datafu-pig/src/test/java/datafu/test/pig/PigTests.java 6fa500d > datafu-pig/src/test/java/datafu/test/pig/macros/MacroTests.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/61378/diff/2/ > > > Testing > ------- > > Gradle pig-tests run successfully > > > Thanks, > > Eyal Allweil > >