+1 - Checked signature and shasum - Successful build - Spurious failure in kll_test; ok on re-run - tox ran after linking in pybind11
But we also have an open issue. Not sure if we should determine the cause of that first? jon On Mon, Jul 5, 2021 at 9:16 AM David Cromberge < [email protected]> wrote: > Hi, > > +1 from me. > > I have successfully run through all the instructions in the Build & Test > guide on the 3.1.0-rc1 candidate. > > Thanks, > David > > On 1 Jul 2021, at 22:53, Alexander Saydakov < > [email protected]> wrote: > > Hello Apache DataSketches PMC and Community, > > This is a call for vote to release Apache DataSketches-cpp candidate > version: 3.1.0-rc1 > > Changes since the last release 3.0.0: > - Kolmogorov-Smirnov test for KLL sketch > - custom seed support in Theta Jaccard similarity > - Theta union bug fix > - added get_max_serialized_size_bytes method for KLL and CPC sketches > - added wrapped_compact_theta_sketch to avoid some cost of > deserialization > - massive code cleanup to avoid compiler warnings > - iterator fix in KLL sketch > - iterator fix in REQ sketch > - exception safety fix in theta_update_sketch_base > - misaligned access fix in MurmurHash3 > > Source repository: > - https://github.com/apache/datasketches-cpp > <https://www.google.com/url?q=https://github.com/apache/datasketches-cpp&source=gmail-imap&ust=1625781259000000&usg=AOvVaw22pPo8txxkKerC3BJkEIvC> > > Git Tag for this release: > - https://github.com/apache/datasketches-cpp/tree/3.1.0-rc1 > <https://www.google.com/url?q=https://github.com/apache/datasketches-cpp/tree/3.1.0-rc1&source=gmail-imap&ust=1625781259000000&usg=AOvVaw3CB2G08kxJaTLmRHx4csiY> > on > branch 3.1.x > > Git HashId for this release starts with: 45885c0 > > The Release Candidate / Zip Repository: > - https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.1.0-rc1/ > <https://www.google.com/url?q=https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.1.0-rc1/&source=gmail-imap&ust=1625781259000000&usg=AOvVaw0B-Z66zNCl45P2FvvgkyQp> > > The public signing key can be found in the KEYS file: > - https://dist.apache.org/repos/dist/dev/datasketches/KEYS > <https://www.google.com/url?q=https://dist.apache.org/repos/dist/dev/datasketches/KEYS&source=gmail-imap&ust=1625781259000000&usg=AOvVaw0Kp8CBZkqRlAdYdhujJ6wf> > > > The artifacts have been signed with key: > 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) < > [email protected]> > > Build & Test Guide: > - https://github.com/apache/datasketches-cpp/blob/3.1.0-rc1/README.md > <https://www.google.com/url?q=https://github.com/apache/datasketches-cpp/blob/3.1.0-rc1/README.md&source=gmail-imap&ust=1625781259000000&usg=AOvVaw1gOD_8a0ltMxZOeCsfM0F4> > > The vote will be performed as follows: > - This letter will be published on dev@ and remain open for at least > 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC > votes or a majority of (+1) PMC votes are acquired. Anyone in the community > can vote. > > Please vote accordingly: > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > Thanks, > Alexander Saydakov > [email protected] > > >
