Sorry, I discovered that the version number in CMakeLists.txt (which determines the version on the resulting object if you build the 'package' target) still has 3.5.0. So we need an rc3.
jon On Thu, Oct 27, 2022 at 1:46 PM Alexander Saydakov <[email protected]> wrote: > +1 > > - verified GPG signature > - checked SHA512 sum > - cmake, make, make test > - tox > - reviewed changes in the 3.5.x branch > This release candidate looks good to me. > > On Thu, Oct 27, 2022 at 1:08 PM Jon Malkin <[email protected]> wrote: > >> Thanks for flagging the omission, Lee. >> >> The python instructions can be found here: >> https://github.com/apache/datasketches-cpp/blob/3.5.x/python/README.md >> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/3.5.x/python/README.md__;!!Op6eflyXZCqGR5I!GNCoBx-x7-I0QlJMzy6Q5v1smmiS8-J4lYimYjTieVePs0PUnmEOE_U9umwUE34F5FmkjCj15tXQLGqkjaLS$> >> >> Versioning is not a trivial problem since we don't produce a library >> object in c++. >> >> jon >> >> >> On Thu, Oct 27, 2022 at 12:21 PM leerho <[email protected]> wrote: >> >>> +1 (binding) >>> >>> Checked on MacOS 12.6: >>> - successfully downloaded source from dist >>> - installed, compiled and tested datasketches-cpp 3.5.1 >>> - installed, compiled and tested Associated Python 3.5.1 >>> - LICENSE and NOTICE are OK >>> - The README.md is very thorough, excellent! >>> >>> Notes for next time: >>> - The Vote letter should include a link to the python/README.md so >>> reviewers know to also install and test the associated Python. >>> - The cmake build/Release and test scripts do NOT report what version is >>> being installed or tested. This should be simple to add. >>> (Meanwhile, the Python pip install and tox scripts DO report the version >>> being installed and tested.) >>> >>> On Thu, Oct 27, 2022 at 9:58 AM Jon Malkin <[email protected]> wrote: >>> >>>> Hello Apache DataSketches PMC and Community, >>>> >>>> >>>> This is a call for vote to release Apache DataSketches-cpp candidate >>>> version 3.5.1-rc2 >>>> >>>> >>>> This is a patch release intended to fix bugs in the previous release. >>>> We are gearing up for some API-breaking changes in a major release, and >>>> wanted to ensure that anyone who is not yet ready for that migration can >>>> benefit from these fixes. >>>> >>>> >>>> Changes since datasketches-cpp 3.5.0 release: >>>> >>>> - fix python wheel build script to produce valid wheels for Apple >>>> Silicon Macs >>>> >>>> - fix a serialization bug for theta and tuple sketches when sketch had >>>> no entries but was not empty (e.g. the result of an intersection between >>>> disjoint sets) >>>> >>>> >>>> Changes since rc1: >>>> >>>> - Should be using the correct GPG signing key (having found my >>>> original one) >>>> >>>> - Source should be entirely unchanged, down to using the same git >>>> hashid >>>> >>>> >>>> Source repository: >>>> >>>> - https://github.com/apache/datasketches-cpp >>>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp__;!!Op6eflyXZCqGR5I!GNCoBx-x7-I0QlJMzy6Q5v1smmiS8-J4lYimYjTieVePs0PUnmEOE_U9umwUE34F5FmkjCj15tXQLJkvnPyg$> >>>> >>>> >>>> Git Tag for this release: >>>> >>>> - https://github.com/apache/datasketches-cpp/releases/tag/3.5.1-rc2 >>>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/releases/tag/3.5.1-rc2__;!!Op6eflyXZCqGR5I!GNCoBx-x7-I0QlJMzy6Q5v1smmiS8-J4lYimYjTieVePs0PUnmEOE_U9umwUE34F5FmkjCj15tXQLOiwnxzg$> >>>> on branch 3.5.x >>>> >>>> >>>> Git HashId for this release is: >>>> bbf236fcd3f88299873442ede207426a72b3170c >>>> >>>> >>>> The Release Candidate / Zip Repository, including convenience binaries >>>> (in pypi subdirectory): >>>> >>>> - >>>> https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.5.1-rc2/ >>>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/cpp/3.5.1-rc2/__;!!Op6eflyXZCqGR5I!GNCoBx-x7-I0QlJMzy6Q5v1smmiS8-J4lYimYjTieVePs0PUnmEOE_U9umwUE34F5FmkjCj15tXQLOyrtHjB$> >>>> >>>> >>>> The public signing key can be found in the KEYS file: >>>> >>>> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS >>>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!GNCoBx-x7-I0QlJMzy6Q5v1smmiS8-J4lYimYjTieVePs0PUnmEOE_U9umwUE34F5FmkjCj15tXQLFBMb-xe$> >>>> >>>> >>>> >>>> The artifacts have been signed with key: >>>> >>>> 21B541A98F6038F334CC 2020-04-30 Jon Malkin (Apache code signing) < >>>> [email protected]> >>>> >>>> >>>> Build & Test Guide: >>>> >>>> - https://github.com/apache/datasketches-cpp/blob/3.5.x/README.md >>>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/3.5.x/README.md__;!!Op6eflyXZCqGR5I!GNCoBx-x7-I0QlJMzy6Q5v1smmiS8-J4lYimYjTieVePs0PUnmEOE_U9umwUE34F5FmkjCj15tXQLEGZaQdp$> >>>> >>>> >>>> The vote will be performed as follows: >>>> >>>> - This letter will be published on dev@ and remain open for at >>>> least 72 hours (excluding weekends and holidays), AND until at least 3 (+1) >>>> PMC votes or a majority of (+1) PMC votes are acquired. Anyone in the >>>> community can vote. >>>> >>>> >>>> Please vote accordingly: >>>> >>>> >>>> [ ] +1 approve >>>> >>>> [ ] +0 no opinion >>>> >>>> [ ] -1 disapprove with the reason >>>> >>>> >>>> Thank you, >>>> >>>> Jon Malkin >>>> >>>> [email protected] >>>> >>>
