There has been enough time for everyone to cast a vote, and we have 3 positive binding votes. Please consider this vote closed. Thank you.
On Mon, Dec 5, 2022 at 1:26 PM David Cromberge <[email protected]> wrote: > Hi all, > > Apologies for the late vote (+1). > > I checked: > > - LICENCE and NOTICE correct. > - Verified shasum signature > - Verified GPG signature > - Tested build and install on OSX > - cmake build and test > - python build and test via tox. > > Thank you, > David > > On 2022/11/28 18:46:16 leerho wrote: > > +1 (binding) > > I checked: > > - ASC signature > > - SHA512 signature > > - cmake build and build test > > - python build and test > > - LICENSE and NOTICE > > - git.properties: > > NIT: once we release, the Git-Commit-Tag should be set to "4.0.0" and > > not "4.0.0-rc1". Everything else (except the time stamp) should be the > > same, I think. > > > > On Fri, Nov 18, 2022 at 12:46 PM Jon Malkin <[email protected]> > wrote: > > > > > +1 (binding) > > > > > > I checked: > > > - LICENSE and NOTICE present and valid > > > - Valid shasum and GPG signature on main source files > > > - Valid shasum and GPG signature on all pypi files > > > - Configure, build, and test in C++ > > > - Ran python tests via tox > > > - Installed in venv and ensured imports work > > > - Ran valgrind on all test binaries to confirm no leaks > > > > > > I did discover a few uses of uninitialized memory in conditionals via > > > valgrind. They seem to be from checking values in stream > deserialization > > > read after a stream has already reached the end. We should definitely > tidy > > > up our stream handling a bit more, but these aren't new so I don't > think > > > they're blockers. > > > > > > jon > > > > > > On Tue, Nov 15, 2022 at 4:39 PM Alexander Saydakov > > > <[email protected]> wrote: > > > > > >> Hello Apache DataSketches PMC and Community, > > >> > > >> > > >> This is a call for vote to release Apache DataSketches-cpp candidate > > >> version 4.0.0-rc1 > > >> > > >> > > >> This is a major release with some API-breaking changes. > > >> > > >> > > >> Changes since datasketches-cpp 3.5.1 release: > > >> > > >> - Common sorted view used by all quantiles sketches with > > >> simultaneous support for both inclusive and exclusive modes > > >> > > >> - The default mode for all methods for querying quantiles sketches > > >> was changed from exclusive to inclusive > > >> > > >> - The mode is now a method parameter, not a template parameter > > >> > > >> - Queries of empty quantiles sketches such as get_rank() and > > >> get_quantile() will throw an exception now (returned NaN for floating > point > > >> types before) > > >> > > >> - SerDe was removed from class templates and added to the relevant > > >> method templates (such as serialize and deserialize) > > >> > > >> - Support for comparator instances in quantiles sketches > > >> > > >> - Support for equality operator instance in frequent items sketch > > >> > > >> - Added operator-> to iterators over quantiles sketches > > >> > > >> > > >> Source repository: > > >> > > >> - > https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp__;!!Op6eflyXZCqGR5I!B2ekCSxzACBHltMOb_2tNIIXl83855rm5QTpU-d5py3ktq0SvV-MGLZARZE3UbjC1HpOD2H9ZUD54R1Lay6kRw$ > > >> > > >> > > >> Git Tag for this release: > > >> > > >> - > https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/releases/tag/4.0.0-rc1__;!!Op6eflyXZCqGR5I!B2ekCSxzACBHltMOb_2tNIIXl83855rm5QTpU-d5py3ktq0SvV-MGLZARZE3UbjC1HpOD2H9ZUD54R2nGCmebA$ > on > > >> branch 4.0.x > > >> > > >> > > >> Git HashId for this release is: > 858a35983e028bd47a3c34324ea2f4d640a7fd49 > > >> > > >> > > >> The Release Candidate / Zip Repository, including convenience binaries > > >> (in pypi subdirectory): > > >> > > >> - > https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/cpp/4.0.0-rc1/__;!!Op6eflyXZCqGR5I!B2ekCSxzACBHltMOb_2tNIIXl83855rm5QTpU-d5py3ktq0SvV-MGLZARZE3UbjC1HpOD2H9ZUD54R20vLpTew$ > > >> > > >> > > >> The public signing key can be found in the KEYS file: > > >> > > >> - > https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!B2ekCSxzACBHltMOb_2tNIIXl83855rm5QTpU-d5py3ktq0SvV-MGLZARZE3UbjC1HpOD2H9ZUD54R33_yAPag$ > > >> < > https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$ > > > > >> > > >> > > >> > > >> The artifacts have been signed with key: > > >> > > >> 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING > KEY) < > > >> [email protected]> > > >> > > >> > > >> Build & Test Guide (C++): > > >> > > >> - > https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/4.0.x/README.md__;!!Op6eflyXZCqGR5I!B2ekCSxzACBHltMOb_2tNIIXl83855rm5QTpU-d5py3ktq0SvV-MGLZARZE3UbjC1HpOD2H9ZUD54R0TBLVExA$ > > >> > > >> > > >> Build & Test Guide (Python): > > >> > > >> - > > >> > https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/4.0.x/python/README.md__;!!Op6eflyXZCqGR5I!B2ekCSxzACBHltMOb_2tNIIXl83855rm5QTpU-d5py3ktq0SvV-MGLZARZE3UbjC1HpOD2H9ZUD54R1B0S0H2w$ > > >> > > >> > > >> The vote will be performed as follows: > > >> > > >> - This letter will be published on dev@ and remain open for at > least > > >> 72 hours (excluding weekends and holidays), AND until at least 3 (+1) > PMC > > >> votes or a majority of (+1) PMC votes are acquired. Anyone in the > > >> community can vote. > > >> > > >> > > >> Please vote accordingly: > > >> > > >> > > >> [ ] +1 approve > > >> > > >> [ ] +0 no opinion > > >> > > >> [ ] -1 disapprove with the reason > > >> > > >> > > >> Thank you, > > >> > > >> Alexander Saydakov > > >> > > >> [email protected] > > >> > > >> > > >> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
