+1 Checked (on OS X Ventura 13.0.1)
- Verify checksum and shasum signatures for cpp distribution - Built cpp and run tests - Make and install local package using cmake - Built python and run tests using tox - Checked README, NOTICE and LICENSE - licence headers on new density sketch sources / tests Well done to the team for all the improvements / enhancements in this release, David On 2023/04/28 22:21:52 Lee Rhodes wrote: > +1 > The whole process ran very smoothly. > > My checks (macOS Ventura 13.3.1) > > - Verify shasum and signature for source release > - cmake -S . -B build/Release -DCMAKE_BUILD_TYPE=Release > - cmake --build build/Release -t all test > - python3 -m pip install . > - tox > > Two minor issues: > > - The Python README.md doesn't include the new Tuple Sketch in the list > of available sketches. > - The copyright year needs to be updated to 2023 in NOTICE (Will already > mentioned this as well) > > Lee. > > > On Wed, Apr 26, 2023 at 11:38 AM Alexander Saydakov > <[email protected]> wrote: > > > Hello Apache DataSketches PMC and Community, > > > > > > This is a call for vote to release Apache DataSketches-cpp candidate > > version 4.1.0-rc1 > > > > > > Changes since datasketches-cpp 4.0.0 release (5 Dec 2022): > > > > - HLL union speed improvement > > > > - Fixed a bug in theta and tuple union base > > > > - new density sketch > > > > - new count min sketch > > > > - thread local random generator > > > > - generic quantile sketches in Python (KLL, REQ, classic quantiles) > > > > - generic frequent items sketch in Python > > > > - generic tuple sketch in Python > > > > - added optional compression of serialized theta sketch > > > > - iterators use new style (no inheritance from std::iterator) > > > > > > Source repository: > > > > - https://github.com/apache/datasketches-cpp > > > > > > Git Tag for this release: > > > > - https://github.com/apache/datasketches-cpp/releases/tag/4.1.0-rc1 on > > branch 4.1.x > > > > > > Git HashId for this release is: c3abaaefe5fa400eed99e082af07c1b61a7144db > > > > > > The Release Candidate / Zip Repository, including convenience binaries (in > > pypi subdirectory): > > > > - https://dist.apache.org/repos/dist/dev/datasketches/cpp/4.1.0-rc1/ > > > > > > The public signing key can be found in the KEYS file: > > > > - https://dist.apache.org/repos/dist/dev/datasketches/KEYS > > <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$> > > > > > > > > The artifacts have been signed with key: > > > > 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) < > > [email protected]> > > > > > > Build & Test Guide (C++): > > > > - https://github.com/apache/datasketches-cpp/blob/4.1.x/README.md > > > > > > Build & Test Guide (Python): > > > > - > > https://github.com/apache/datasketches-cpp/blob/4.1.x/python/README.md > > > > > > The vote will be performed as follows: > > > > - This letter will be published on dev@ and remain open for at least > > 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC > > votes or a majority of (+1) PMC votes are acquired. Anyone in the > > community can vote. > > > > > > Please vote accordingly: > > > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove with the reason > > > > > > Thank you, > > > > Alexander Saydakov > > > > [email protected] > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
