jmalkin commented on issue #20: URL: https://github.com/apache/datasketches-python/issues/20#issuecomment-1847671417
Since we just got issues enabled, I created this after doing a bunch of the work. I'm not entirely sure how best to check if memory is being handled properly from w/in C++, but I managed to port over all the core C++ sketches. Still need to figure out vector_of_kll, which is python-specific. Tests all pass after fixing a move()-related bug in KLL. Haven't tested performance yet. Our unit tests aren't long enough for that to be a big issue, and I'm trying to decide how much we need. Benchmarking can be an infinite rabbit hole if you allow it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
