+1 (Non-Binding) - Verified compilation with mvn install - Verified that the 5.0.1-RC1 build<https://dist.apache.org/repos/dist/dev/datasketches/java/5.0.1-RC1> fixes the bug from GH Issue #484.
On 2023/12/22 19:26:49 Alexander Saydakov wrote: > +1 > - checked GPG signature and SHA512 sum > - license and notice look good > - "mvn test" successful > > On Fri, Dec 22, 2023 at 5:30 AM David Cromberge > <[email protected]<mailto:[email protected]>> > wrote: > > > +1 > > > > Checked: > > - LICENSE and NOTICE files > > - README file content > > - mvn clean test > > - mvn install > > > > David > > > > On 2023/12/22 08:58:26 Pierre Lacave wrote: > > > +1 (non-binding) > > > > > > - mvn clean install ran successfully with OpenJDK 11 (aarch64) > > > > > > On Fri, Dec 22, 2023 at 9:18 AM Jon Malkin > > > <[email protected]<mailto:[email protected]>> wrote: > > > > > > > +1 (binding) > > > > > > > > - checksum and signature are good (maven files, too) > > > > - mvn clean package ran cleanly > > > > - LICENSE and NOTICE present and appear valid > > > > > > > > jon > > > > > > > > On Thu, Dec 21, 2023 at 2:29 PM Lee Rhodes > > > > <[email protected]<mailto:[email protected]>> wrote: > > > > > > > >> The above earliest voting close date is incorrect. It should be: > > > >> > > > >> This vote will close no earlier than Thursday, Dec 27 2:30 PM PST. > > > >> > > > >> On Thu, Dec 21, 2023 at 2:07 PM Lee Rhodes > > > >> <[email protected]<mailto:[email protected]>> wrote: > > > >> > > > >>> Hello Apache DataSketches PMC and Community, > > > >>> > > > >>> *The issues addressed in this Bug-fix release:* > > > >>> > > > >>> A. PR 482,483 HLL Union toString is not pure and can trigger a > > rebuild. > > > >>> Added Final. > > > >>> > > > >>> B. PR 485 Remove duplicate code, fixed KLL toString printing issue, > > > >>> minor cleanup, improved diagnostic detail printout of internal KLL > > data > > > >>> array and levels array. Resolved some CodeQL issues. > > > >>> > > > >>> C. Issue 484, PR 486 KllItemsSketch<Boolean> The serDe of min and max > > > >>> were mingled with the serDe of Boolean Items and they should not be. > > Added > > > >>> the same test to classic quantiles to make sure that the same issue > > does > > > >>> not appear there. > > > >>> > > > >>> *Release Details* > > > >>> > > > >>> 1. This is a call for vote to release Apache DataSketches-java > > candidate > > > >>> version: * 5.0.1-RC1* > > > >>> > > > >>> NOTE 1: This is the core Java component of the DataSketches > > library > > > >>> that includes all the sketch algorithms in production-ready > > packages. These > > > >>> sketches can be called directly from this component or used in > > conjunction > > > >>> with the adaptor components such as Hadoop Pig, Hadoop Hive, or the > > > >>> aggregator adaptors built into Apache Druid. > > > >>> > > > >>> 2. Source repository: > > > >>> - > > https://github.com/apache/datasketches-java<https://github.com/apache/datasketches-java> > > > >>> > > > >>> Git Tag for this release: > > > >>> - > > https://github.com/apache/datasketches-java/releases/tag/5.0.1-RC1<https://github.com/apache/datasketches-java/releases/tag/5.0.1-RC1> > > > >>> on branch 5.0.X > > > >>> > > > >>> Git HashId for this release starts with: b50100d on branch 5.0.X > > > >>> > > > >>> 3. The Release Candidate / Zip Repository: > > > >>> - > > https://dist.apache.org/repos/dist/dev/datasketches/java/5.0.1-RC1<https://dist.apache.org/repos/dist/dev/datasketches/java/5.0.1-RC1> > > > >>> > > > >>> The public signing key can be found in the KEYS file: > > > >>> - > > https://dist.apache.org/repos/dist/dev/datasketches/KEYS<https://dist.apache.org/repos/dist/dev/datasketches/KEYS> > > > >>> > > > >>> The artifacts have been signed with --keyid-format SHORT : > > 8CD4A902 > > > >>> > > > >>> 4. Repository: Maven Central [Nexus]( > > http://repository.apache.org<http://repository.apache.org> > > ) (Jar > > > >>> Artifacts): > > > >>> - > > > >>> > > https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-java/5.0.1/<https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-java/5.0.1/> > > > >>> > > > >>> 5. Build & Test Guide: > > > >>> - > > > >>> > > https://github.com/apache/datasketches-java/blob/5.0.1-RC1/README.md<https://github.com/apache/datasketches-java/blob/5.0.1-RC1/README.md> > > > >>> > > > >>> 6. The vote will be performed as follows: > > > >>> - This letter will be published on dev@ and remain open for at > > least > > > >>> 72 hours (excluding weekends and holidays), AND until at least 3 > > (+1) PMC > > > >>> votes or a majority of (+1) PMC votes are acquired. Anyone in the > > community > > > >>> can vote. This vote will close no earlier than Thursday, Dec 7 > > 11:30 PM > > > >>> PST. > > > >>> > > > >>> Please vote accordingly: > > > >>> > > > >>> [ ] +1 approve > > > >>> [ ] +0 no opinion > > > >>> [ ] -1 disapprove with the reason > > > >>> > > > >>> Thanks, > > > >>> Lee Rhodes > > > >>> [email protected]<mailto:[email protected]> > > > >>> > > > >>> > > > >>> > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: > > [email protected]<mailto:[email protected]> > > For additional commands, e-mail: > > [email protected]<mailto:[email protected]> > > > > >
