+1(binding) - cmake and cmake ... RUN_TESTS work fine. - checked GPG signature and SHA512 sum
On Fri, Jan 5, 2024 at 11:39 AM Alexander Saydakov <sayda...@yahooinc.com.invalid> wrote: > +1 > > - looked at the very simple change since 5.0.1 > - checked GPG signature and SHA512 sum > - "cmake", "make" and "make test" successful > > > On Fri, Jan 5, 2024 at 6:28 AM Charlie Dickens > <charlie.dick...@yahooinc.com.invalid> wrote: > >> +1 >> >> Checked signing keys and shasum >> built and ran unit tests that all passed on mac os 13.6.3 >> >> >> On Fri, 5 Jan 2024 at 00:10, Jon Malkin <jmal...@apache.org> wrote: >> >>> Hello Apache DataSketches PMC and Community, >>> >>> >>> This is a call for vote to release Apache DataSketches-cpp candidate >>> version 5.0.2-rc1 >>> >>> >>> This is a patch release to ensure compatibility with c++17. >>> >>> Changes since datasketches-cpp 5.0.1 release (December 2023): >>> >>> - density sketch: switch from std::random_shuffle, which was removed >>> in c++17, to std::shuffle >>> >>> Source repository: >>> >>> - https://github.com/apache/datasketches-cpp >>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp__;!!Op6eflyXZCqGR5I!A1OWQ3StKFGOiM4yGUtRR7XR5vhCH4cDDLS1CgtGGef8joXioHwhaUGup3idGppdIw1hvhm1MoKrrDUNexLDXKopng$> >>> >>> >>> Git Tag for this release: >>> >>> - https://github.com/apache/datasketches-cpp/releases/tag/5.0.2-rc1 >>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/releases/tag/5.0.2-rc1__;!!Op6eflyXZCqGR5I!A1OWQ3StKFGOiM4yGUtRR7XR5vhCH4cDDLS1CgtGGef8joXioHwhaUGup3idGppdIw1hvhm1MoKrrDUNexLQupsf4w$> >>> on >>> branch 5.0.x >>> >>> >>> Git HashId for this release is: d2f7031529c2bb1444063e1dc908cc63cc9c35b8 >>> >>> >>> The Release Candidate Zip Repository: >>> >>> - https://dist.apache.org/repos/dist/dev/datasketches/cpp/5.0.2-rc1/ >>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/cpp/5.0.2-rc1/__;!!Op6eflyXZCqGR5I!A1OWQ3StKFGOiM4yGUtRR7XR5vhCH4cDDLS1CgtGGef8joXioHwhaUGup3idGppdIw1hvhm1MoKrrDUNexK6iIm93g$> >>> >>> >>> The public signing key can be found in the KEYS file: >>> >>> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS >>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$> >>> >>> >>> >>> The artifacts have been signed with key: >>> >>> 41A98F6038F334CC Jon Malkin (Apache code signing) < >>> jmal...@users.noreply.github.com> >>> >>> >>> Build & Test Guide (C++): >>> >>> - >>> https://github.com/apache/datasketches-cpp/blob/5.0.2-rc1/README.md >>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/5.0.2-rc1/README.md__;!!Op6eflyXZCqGR5I!A1OWQ3StKFGOiM4yGUtRR7XR5vhCH4cDDLS1CgtGGef8joXioHwhaUGup3idGppdIw1hvhm1MoKrrDUNexJka8mhpA$> >>> >>> >>> The vote will be performed as follows: >>> >>> - This letter will be published on dev@ and remain open for at least >>> 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC >>> votes or a majority of (+1) PMC votes are acquired. Anyone in the >>> community can vote. >>> >>> >>> Please vote accordingly: >>> >>> >>> [ ] +1 approve >>> >>> [ ] +0 no opinion >>> >>> [ ] -1 disapprove with the reason >>> >>> >>> Thank you, >>> >>> Jon Malkin >>> >>> jmal...@apache.org >>> >>
