I need to vote on my own RC: -1 (binding)
Did fresh testing and happened to pick a sketch that apparently leaks ... something. I believe it was the python portion of joint Python/C++ objects like the density_sketch's kernel_function or the tuple_sketch's tuple_policy. I believe I have a proper fix, not a workaround, and also cleaned up the API a bit more. Will work on RC2 later, I hope in a few hours. jon On Wed, Jan 24, 2024 at 12:31 PM Alexander Saydakov <[email protected]> wrote: > +1 > > - checked license and notice > - checked GPG signature and shasum > - tox tests passed > > On Wed, Jan 24, 2024 at 8:19 AM Charlie Dickens > <[email protected]> wrote: > >> +1 >> >> verified signatures and shasum >> built in a virtual environment >> Install via python -m pip install . in project root >> Installed tox and ran unit tests which all passed >> Played with some basic examples in ipython which seemed fine. >> >> On Wed, 24 Jan 2024 at 08:07, Jon Malkin <[email protected]> wrote: >> >>> Hello Apache DataSketches PMC and Community, >>> >>> >>> This is a call for vote to release Apache DataSketches-python candidate >>> version 5.0.0-rc1 >>> >>> >>> This will be the first stand-alone Python release, although continuing >>> the version numbering used when this portion of the project was bundled >>> with the C++ release. >>> >>> >>> This is also a major version release with several significant changes: >>> * Vastly improved API documentation via sphinx >>> * More pythonic API: >>> * __copy__ instead of C++-style copy constructors >>> * __str__ takes no arguments in all cases >>> * Moved from pybind11 to nanobind, which also requires c++17 internally >>> * Added new exact proportional to size sampling sketch, ebpps_sketch >>> * Fixed slowness with theta intersection >>> * Fixed incompatibility with Java's serialized empty frequent items >>> sketch >>> * Removed default Kernel for density sketch (GaussianKernel is still >>> provided) >>> * Removed extra (largely transparent to users) wrappers around >>> density_sketch and tuple_sketch >>> >>> Source repository: >>> >>> - https://github.com/apache/datasketches-python >>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-python__;!!Op6eflyXZCqGR5I!DLfROK2VJZMYMwsw2vGnz6ASifebissD_Xo0Hu5ySV6mx0qDu3WCXh4eXJjL4PP1dh3aEpBwctzL3ajHLL3nifTcWg$> >>> >>> >>> Git Tag for this release: >>> >>> - >>> https://github.com/apache/datasketches-python/releases/tag/5.0.0-rc1 >>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-python/releases/tag/5.0.0-rc1__;!!Op6eflyXZCqGR5I!DLfROK2VJZMYMwsw2vGnz6ASifebissD_Xo0Hu5ySV6mx0qDu3WCXh4eXJjL4PP1dh3aEpBwctzL3ajHLL2KqyF-yA$> >>> on >>> branch 5.0.x >>> >>> >>> Git HashId for this release is: 72ba84f34ca8e351efbfeff99f6a8b943f491068 >>> >>> >>> The Release Candidate Zip Repository: >>> >>> - >>> https://dist.apache.org/repos/dist/dev/datasketches/python/5.0.0-rc1/ >>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/python/5.0.0-rc1/__;!!Op6eflyXZCqGR5I!DLfROK2VJZMYMwsw2vGnz6ASifebissD_Xo0Hu5ySV6mx0qDu3WCXh4eXJjL4PP1dh3aEpBwctzL3ajHLL1TyZL1MQ$> >>> >>> >>> The public signing key can be found in the KEYS file: >>> >>> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS >>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$> >>> >>> >>> >>> The artifacts have been signed with key: >>> >>> 41A98F6038F334CC Jon Malkin (Apache code signing) < >>> [email protected]> >>> >>> >>> Build & Test Guide: >>> >>> - >>> https://github.com/apache/datasketches-python/blob/5.0.0-rc1/README.md >>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-python/blob/5.0.0-rc1/README.md__;!!Op6eflyXZCqGR5I!DLfROK2VJZMYMwsw2vGnz6ASifebissD_Xo0Hu5ySV6mx0qDu3WCXh4eXJjL4PP1dh3aEpBwctzL3ajHLL1A4vserA$> >>> >>> >>> The vote will be performed as follows: >>> >>> - This letter will be published on dev@ and remain open for at least >>> 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC >>> votes or a majority of (+1) PMC votes are acquired. Anyone in the >>> community can vote. >>> >>> >>> Please vote accordingly: >>> >>> >>> [ ] +1 approve >>> >>> [ ] +0 no opinion >>> >>> [ ] -1 disapprove with the reason >>> >>> >>> Thank you, >>> >>> Jon Malkin >>> >>> [email protected] >>> >>
