mcgrawia commented on issue #43: URL: https://github.com/apache/datasketches-python/issues/43#issuecomment-2045177715
thanks so much @jmalkin! I can confirm the fix is working for the Dockerfile above. Oddly, when I tried to integrate this into our bigger project Dockerfile, which uses `alpine-sdk` for the build dependencies, it seems like a different failure occurs: ```dockerfile FROM python:3.12-alpine # install build deps RUN apk add --no-cache alpine-sdk RUN pip3 install --no-cache-dir datasketches~=5.0 ``` error: `inlining failed in call to 'always_inline' 'vsnprintf': function body can be overwritten at link time` ``` ... warnings 57.97 [100%] Linking CXX shared module /tmp/pip-install-gm_4i67f/datasketches_2a992777b0d04ced877a17bcfc35ec82/build/lib.linux-x86_64-cpython-312/_datasketches.abi3.so 57.97 /usr/include/fortify/stdio.h: In function '__to_xstring.constprop': 57.97 /usr/include/fortify/stdio.h:73:28: error: inlining failed in call to 'always_inline' 'vsnprintf': function body can be overwritten at link time 57.97 73 | _FORTIFY_FN(vsnprintf) int vsnprintf(char * _FORTIFY_POS0 __s, size_t __n, 57.97 | ^ 57.97 /usr/include/c++/13.2.1/ext/string_conversions.h:113:32: note: called from here 57.97 113 | const int __len = __convf(__s, __n, __fmt, __args); 57.97 | ^ 57.97 make[4]: *** [/tmp/ccfmmEMl.mk:62: /tmp/ccoFhfle.ltrans20.ltrans.o] Error 1 57.97 make[4]: *** Waiting for unfinished jobs.... 57.97 lto-wrapper: fatal error: make returned 2 exit status 57.97 compilation terminated. 57.97 /usr/lib/gcc/x86_64-alpine-linux-musl/13.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: error: lto-wrapper failed 57.97 collect2: error: ld returned 1 exit status 57.97 gmake[3]: *** [CMakeFiles/python.dir/build.make:338: /tmp/pip-install-gm_4i67f/datasketches_2a992777b0d04ced877a17bcfc35ec82/build/lib.linux-x86_64-cpython-312/_datasketches.abi3.so] Error 1 57.97 gmake[2]: *** [CMakeFiles/Makefile2:87: CMakeFiles/python.dir/all] Error 2 57.97 gmake[1]: *** [CMakeFiles/Makefile2:94: CMakeFiles/python.dir/rule] Error 2 57.97 gmake: *** [Makefile:124: python] Error 2 ``` But we were able to work around it by just using the packages from the list in the original docker file above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
