jmalkin commented on issue #49: URL: https://github.com/apache/datasketches-python/issues/49#issuecomment-2350850765
As far as I know, nothing! It should work if you remove the version restriction. Several years ago we were hit with an error when a new python came out numpy hadn't upgraded to use that. Since then we've been pinning versions to avoid unexpected gotchas. But in this case, we have.. I think exactly 1 call to a numpy API and that one didn't change to 2.0. If you build from source it should work to just remove the version restriction. But it's been enough months that we should be able to safely move -- except that it'll also be a major version bump since it can cause incompatibility when integrating our library, even if our own API doesn't change! We added bloom filter support in C++ so maybe I'll try to get that added to this package so it feels like our major version has something beyond the numpy version change. But if I can't get that done quickly then maybe we'll just do a version bump in isolation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
