+1 (binding) - Checked signatures of the core release zip and maven subdir - LICENSE and NOTICE look good - tested on my linux box: - java 8: mvn clean test -- ok - java 11: mvn clean test -- ok - java 17: mvn test -- invalid version (no clean) - java 21: mvn test -- invalid version (no clean)
This seems expected, and happily we already have a vote testing using the compiled library in a real project. jon On Tue, Oct 1, 2024 at 4:22 PM Alexander Saydakov <[email protected]> wrote: > +1 > > - checked gpg and shasum > - LICANSE and NOTICE look fine > - "mvn test" passes (openjdk 11) > > On Tue, Oct 1, 2024 at 9:02 AM Yang Jie <[email protected]> wrote: > >> +1, this version is still fine for me, Thanks Lee Rhodes ~ >> >> Jie Yang >> >> On 2024/10/01 01:27:25 Lee Rhodes wrote: >> > *Key Changes From Last Release* >> > ### Removed a Java version check that prevented running with Java 21 in >> > limited mode. Java 21 is not supported, but if the user is not using >> > off-heap memory it is still possible to use this memory component with >> Java >> > 21. One cannot compile with Java 21, but running with Java 21 in this >> > limited mode may work OK. >> > #### RC2: Found 2 places where this was being checked. Removed the >> > duplicate check. >> > >> > ### Renamed the artifact of the root project from >> > "datasketches-memory-root" to "datasketches-memory". This was >> preventing >> > some environments in obtaining the correct jar files from Maven Central. >> > >> > ### Removed a thrown exception in case where the user attempts to close >> a >> > non-AutoCloseable memory object. With the current object hierarchy, some >> > static analyzers may flag a false-positive potential memory leak >> warning on >> > some >> > instances of non-AutoClosable memory objects. Examples include Memory >> > objects that are explicitly on-heap (i.e., arrays) or wrapped >> ByteBuffers. >> > >> > ### Improved the code comments and printed output for the >> > ExampleMemoryRequestServerTest class. >> > >> > #### RD2: README: Cleaned up confusing references to release versions. >> > >> > *Hello Apache DataSketches PMC and Community, * >> > 1. This is a call for vote to release Apache DataSketches-memory >> candidate >> > version: 3.0.2-RC2 >> > >> > 2. Source repository: >> > >> > - >> https://urldefense.com/v3/__https://github.com/apache/datasketches-memory__;!!Op6eflyXZCqGR5I!HX5RkTOob-0nRVTnxndcAUDZAo1lRhrW_ip1YcOWeWz1dgFHeYQeMqft0Zn3DN4B0pwAB7OOGNtRU6ZNMfO3$ >> > >> > Git Tag for this release: >> > - >> https://urldefense.com/v3/__https://github.com/apache/datasketches-memory/tree/3.0.2-RC2__;!!Op6eflyXZCqGR5I!HX5RkTOob-0nRVTnxndcAUDZAo1lRhrW_ip1YcOWeWz1dgFHeYQeMqft0Zn3DN4B0pwAB7OOGNtRU-Ubpq7X$ >> on branch >> > 3.0.X >> > >> > Git HashId for this release starts with: 9fd3b45 >> > >> > >> > 3. The Release Candidate / Zip Repository: >> > >> > - >> https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/memory/3.0.2-RC2/__;!!Op6eflyXZCqGR5I!HX5RkTOob-0nRVTnxndcAUDZAo1lRhrW_ip1YcOWeWz1dgFHeYQeMqft0Zn3DN4B0pwAB7OOGNtRU1qC4G4q$ >> > >> > >> > The public signing key can be found in the KEYS file: >> > >> > - >> https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!HX5RkTOob-0nRVTnxndcAUDZAo1lRhrW_ip1YcOWeWz1dgFHeYQeMqft0Zn3DN4B0pwAB7OOGNtRU9NdF2AB$ >> > >> > >> > The artifacts have been signed with --keyid-format SHORT : 8CD4A902 >> > >> > >> > 4. Repository: Maven Central [Nexus]( >> https://urldefense.com/v3/__https://repository.apache.org__;!!Op6eflyXZCqGR5I!HX5RkTOob-0nRVTnxndcAUDZAo1lRhrW_ip1YcOWeWz1dgFHeYQeMqft0Zn3DN4B0pwAB7OOGNtRU2lKc12v$ >> ) (Jar >> > Artifacts): >> > >> > - >> > >> https://urldefense.com/v3/__https://repository.apache.org/content/repositories/orgapachedatasketches-1062/org/apache/datasketches/datasketches-memory/3.0.2__;!!Op6eflyXZCqGR5I!HX5RkTOob-0nRVTnxndcAUDZAo1lRhrW_ip1YcOWeWz1dgFHeYQeMqft0Zn3DN4B0pwAB7OOGNtRU-QodwtE$ >> > / >> > >> > >> > 5. Build & Test Guide: >> > >> > - >> https://urldefense.com/v3/__https://github.com/apache/datasketches-memory/blob/3.0.2-RC2/README.md__;!!Op6eflyXZCqGR5I!HX5RkTOob-0nRVTnxndcAUDZAo1lRhrW_ip1YcOWeWz1dgFHeYQeMqft0Zn3DN4B0pwAB7OOGNtRUwbGYbdU$ >> > >> > >> > 6. The vote will be performed as follows: >> > >> > - This letter will be published on dev@ and remain open for >> > >> > - at least 72 hours (excluding weekends and holidays), AND >> > >> > - until at least 3 (+1) PMC votes or a majority of (+1) PMC votes are >> > acquired. >> > >> > - Anyone in the community can vote. >> > - This vote will close no earlier than Thursday, Oct 3, 2024, 6:00 PM >> > Pacific. >> > >> > >> > Please vote accordingly: >> > [ ] +1 approve >> > [ ] +0 no opinion >> > [ ] -1 disapprove with the reason >> > >> > Thanks, >> > Lee Rhodes >> > [email protected] >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >>
