+1 - checked GPG and SHA - checked NOTICE and LICENSE - 'make', 'make install', 'make test' run successfully
On Fri, Jan 17, 2025 at 3:19 PM Jon Malkin <[email protected]> wrote: > +1 (binding) > > * LICENSE ok > * as Lee noted, NOTICE is ok but should say 2025 > * Signature and shasum valid > * Local tests ran ok. Wasn't sure about implications of enabling cloud > builds on my test project so didn't test cloud build > > jon > > On Wed, Jan 15, 2025 at 5:03 PM Lee Rhodes <[email protected]> wrote: > > > > +1(binding) > > > > * NOTICE OK, but needs to be updated to 2025 for next time. > > * LICENSE OK > > * Git Hash is correct > > * GPG signature & SHA hash OK > > * Logged in and authenticated successfully > > * make, make install, make test worked fine > > * However the 'dataform test' issued a warning that we may need the BQ > folks to explain: > > * dataform test > > > > Compiling... > > > > > > (node:42572) [DEP0040] DeprecationWarning: The `punycode` module is > deprecated. Please use a userland alternative instead. > > > > (Use `node --trace-deprecation ...` to show where the warning was > created) > > > > Compiled successfully. > > > > * Nonetheless, all of our tests passed. > > > > > > On Wed, Jan 15, 2025 at 3:15 PM Alexander Saydakov > <[email protected]> wrote: > >> > >> Hello Apache DataSketches PMC and Community, > >> > >> > >> This is a call for vote to release Apache DataSketches-bigquery > candidate version 1.0.1-rc3 > >> > >> > >> Apache DataSketches library functions for Google BigQuery. > >> > >> This is a patch release with a few small changes: > >> - added installation of wget and unzip in cloudbuild.yaml for > deployment to BigQuery > >> - updated dependency on datasketches-cpp to version 5.2.0 (Theta > compression bug fix) > >> > >> Source repository: > >> > >> - > https://urldefense.com/v3/__https://github.com/apache/datasketches-bigquery__;!!Op6eflyXZCqGR5I!A4yEfnVNk0BhJ49-NRtVBl_HtdClHOYPiYRpllV48Y-Ih3ASOJV7KShtskJ1-LKEhIIFJj9l-OkcgV5_Og$ > >> > >> > >> Git Tag for this release: > >> > >> - > https://urldefense.com/v3/__https://github.com/apache/datasketches-bigquery/releases/tag/1.0.1-rc3__;!!Op6eflyXZCqGR5I!A4yEfnVNk0BhJ49-NRtVBl_HtdClHOYPiYRpllV48Y-Ih3ASOJV7KShtskJ1-LKEhIIFJj9l-OkWvx20zQ$ > on branch 1.0.x > >> > >> > >> Git HashId for this release is: 2ea221be10bfecb08fe5c061b8f8aad6cf47171c > >> > >> The Release Candidate Zip Repository: > >> > >> - > https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/bigquery/1.0.1-rc3/__;!!Op6eflyXZCqGR5I!A4yEfnVNk0BhJ49-NRtVBl_HtdClHOYPiYRpllV48Y-Ih3ASOJV7KShtskJ1-LKEhIIFJj9l-OnWrUrjBw$ > >> > >> > >> The public signing key can be found in the KEYS file: > >> > >> - > https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!A4yEfnVNk0BhJ49-NRtVBl_HtdClHOYPiYRpllV48Y-Ih3ASOJV7KShtskJ1-LKEhIIFJj9l-OlCBA148w$ > >> > >> > >> > >> The artifacts have been signed with key: > >> > >> 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) < > [email protected]> > >> > >> > >> Build & Test Guide: > >> > >> - > https://urldefense.com/v3/__https://github.com/apache/datasketches-bigquery/blob/1.0.1-rc3/README.md__;!!Op6eflyXZCqGR5I!A4yEfnVNk0BhJ49-NRtVBl_HtdClHOYPiYRpllV48Y-Ih3ASOJV7KShtskJ1-LKEhIIFJj9l-Ok1LR6nCw$ > >> > >> > >> The vote will be performed as follows: > >> > >> - This letter will be published on dev@ and remain open for at > least 72 hours (excluding weekends and holidays), AND until at least 3 (+1) > PMC votes or a majority of (+1) PMC votes are acquired. Anyone in the > community can vote. > >> > >> > >> Please vote accordingly: > >> > >> > >> [ ] +1 approve > >> > >> [ ] +0 no opinion > >> > >> [ ] -1 disapprove with the reason > >> > >> > >> Thank you, > >> > >> Alexander Saydakov > >> > >> [email protected] > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
