To clarify, "not a blocker" in this case means I'm mentioning it and don't yet understand why but it's not a problem. The proposed release builds successfully with jdk17, which exactly is the intent with this package. That was just an observation of what happened when I tried to force 21.
On Fri, Jan 17, 2025 at 4:29 PM Jon Malkin <[email protected]> wrote: > > +1 (binding) > > - GPG signature and SHA checksum are ok > - likewise for /maven subdir > - NOTICE and LICENSE look ok > - mvn test works with jdk17, fails with 11 (expected) > - trying to force jdf21 ends up building with 17, possibly due to > backwards compatibility and my toolchain, but not a blocker > > jon > > On Thu, Jan 16, 2025 at 1:06 PM Alexander Saydakov > <[email protected]> wrote: > > > > +1 > > > > - checked GPG and SHA > > - NOTICE and LICENSE look good > > - "mvn test" works using openjdk64-17.0.6 > > > > On Wed, Jan 15, 2025 at 3:05 PM Lee Rhodes <[email protected]> wrote: > >> > >> Hello Apache DataSketches PMC and Community, > >> > >> NOTES: > >> > >> This is a patch release to fix a bug found in the Theta Sketch compression > >> algorithm in release 7.0.0. > >> This version of DataSketches-java leverages the new Panama (FFM) > >> incubation capability introduced with Java 17 (JEP 412). As a result, this > >> version requires Java 17 for both compile and run-time and you will need > >> to add "--add-modules=jdk.incubator.foreign" flag to the JVM. > >> > >> 1. This is a call for vote to release Apache DataSketches-java candidate > >> version: 7.0.1-RC1. > >> > >> NOTE 1: This is the core Java component of the DataSketches library > >> that includes all the sketch algorithms in production-ready packages. > >> These sketches can be called directly from this component or used in > >> conjunction with the adapter components such as Hadoop Pig, Hadoop Hive, > >> the aggregator adapters built into Apache Druid, etc. > >> > >> 2. Source repository: > >> - https://github.com/apache/datasketches-java > >> > >> Git Tag for this release: > >> - https://github.com/apache/datasketches-java/releases/tag/7.0.1-RC1 > >> on branch 7.0.X > >> > >> Git HashId for this release starts with: 624075d on branch 7.0.X > >> > >> 3. The Release Candidate / Zip Repository: > >> - https://dist.apache.org/repos/dist/dev/datasketches/java/7.0.1-RC1 > >> > >> The public signing key can be found in the KEYS file: > >> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS > >> > >> The artifacts have been signed with --keyid-format SHORT : 8CD4A902 > >> > >> 4. Repository: Maven Central [Nexus](http://repository.apache.org) (Jar > >> Artifacts): > >> - > >> https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-java/7.0.1/ > >> > >> 5. Build & Test Guide: > >> - https://github.com/apache/datasketches-java/blob/7.0.1-RC1/README.md > >> > >> 6. The vote will be performed as follows: > >> - This letter will be published on dev@ and remain open for at least 72 > >> hours (excluding weekends and holidays), AND until at least 3 (+1) PMC > >> votes or a majority of (+1) PMC votes are acquired. Anyone in the > >> community can vote. This vote will close no earlier than Wednesday Jan > >> 20, 2025, 3:00 PM PST. > >> > >> Please vote accordingly: > >> > >> [ ] +1 approve > >> [ ] +0 no opinion > >> [ ] -1 disapprove with the reason > >> > >> Thanks, > >> Lee Rhodes > >> [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
