jmalkin opened a new pull request, #18: URL: https://github.com/apache/datasketches-spark/pull/18
I think I now have everything living in `org.apache.spark.sql.datasketches` Some of the traits we extend use constructs like `Seq[AbstractDataType]`, which is fine except that `AbstractDataType` is declared as `private[sql]`, meaning it's only visible to things in `org.apache.spark.sql`. We might be able to get away with using `Seq[DataType]` but that's a subtype of its abstract parent and not everything inherits from it. Similarly, the generic `NumericType` is also not public. These seem like design flaws in Spark, IMHO, but I'm not going to try getting them to change that at this point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
