We found a problem. It turns out that the emscripten compiler does not export HEAPx symbols by default anymore (at least the latest version 4.0.7, and, perhaps, some others). This has to be requested explicitly by setting a parameter. Fortunately, setting the parameter for older versions does not break anything. So we need a small change in one Makefile to make this work with all (hopefully) versions of emscripten. Please consider this vote cancelled. I will prepare rc2 shortly. Thank you.
On Mon, Apr 21, 2025 at 4:06 PM Jon Malkin <[email protected]> wrote: > +1 (binding) > > I checked: > - LICENSE and NOTICE are ok > - shasum and GPG signature check out > - make, make install, make test all worked > > I hadn't realized that the environment variables used are cached at > the time of calling make, so I was briefly confused that make install > failed (I had a wrong location but make clean and restarting worked > ok. > > jon > > On Wed, Apr 16, 2025 at 6:17 PM Alexander Saydakov > <[email protected]> wrote: > > > > Hello Apache DataSketches PMC and Community, > > > > > > This is a call for vote to release Apache DataSketches-bigquery > candidate version 1.1.0-rc1 > > > > > > Apache DataSketches library functions for Google BigQuery. > > > > Changes since the last release 1.0.3 > > - fixed frequent_trings_sketch (issue #146) > > - fixed handling of nulls in the input (issue #145) > > - improved makefiles (better targets, support deploying artifacts to > a subdir in a bucket) > > > > Source repository: > > > > - > https://urldefense.com/v3/__https://github.com/apache/datasketches-bigquery__;!!Op6eflyXZCqGR5I!HY0MuQqvDCe4l7D3z-l9KdiOCXbq4ub9rADBZinzt-D1BC1k2MrfMw6QPddWs6JjZF9IFQshmf6u2XUel4wp$ > > > > > > Git Tag for this release: > > > > - > https://urldefense.com/v3/__https://github.com/apache/datasketches-bigquery/releases/tag/1.1.0-rc1__;!!Op6eflyXZCqGR5I!HY0MuQqvDCe4l7D3z-l9KdiOCXbq4ub9rADBZinzt-D1BC1k2MrfMw6QPddWs6JjZF9IFQshmf6u2QhmLskD$ > on branch 1.1.x > > > > > > Git HashId for this release is: 7076078aa7a52de7500473554303a83b7004e70f > > > > The Release Candidate Zip Repository: > > > > - > https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/bigquery/1.1.0-rc1/__;!!Op6eflyXZCqGR5I!HY0MuQqvDCe4l7D3z-l9KdiOCXbq4ub9rADBZinzt-D1BC1k2MrfMw6QPddWs6JjZF9IFQshmf6u2a-ex6Jd$ > > > > > > The public signing key can be found in the KEYS file: > > > > - > https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!HY0MuQqvDCe4l7D3z-l9KdiOCXbq4ub9rADBZinzt-D1BC1k2MrfMw6QPddWs6JjZF9IFQshmf6u2cMibr0l$ > > > > > > > > The artifacts have been signed with key: > > > > 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) < > [email protected]> > > > > > > Build & Test Guide: > > > > - > https://urldefense.com/v3/__https://github.com/apache/datasketches-bigquery/blob/1.1.0-rc1/README.md__;!!Op6eflyXZCqGR5I!HY0MuQqvDCe4l7D3z-l9KdiOCXbq4ub9rADBZinzt-D1BC1k2MrfMw6QPddWs6JjZF9IFQshmf6u2YvGwzDM$ > > > > > > The vote will be performed as follows: > > > > - This letter will be published on dev@ and remain open for at least > 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC > votes or a majority of (+1) PMC votes are acquired. Anyone in the community > can vote. > > > > > > Please vote accordingly: > > > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove with the reason > > > > > > Thank you, > > > > Alexander Saydakov > > > > [email protected] > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
