leerho opened a new pull request, #683: URL: https://github.com/apache/datasketches-java/pull/683
# Main ## common ### Family * added static initializer check for machine native endianness ### Util * added static initializer check for machine native endianness ### MemorySegmentRequest * Added comments to empty blocks. ### BigEndianNativeOrderNotSupportedException * Removed, replaced with more general SketechesNotSupportedException ### SketechesNotSupportedException * Replaces BigEndianNativeOrderNotSupportedException ## hll ### AbstractCoupons * Added comments to empty blocks. ### DirectCouponHashSet * Simple Reformating, no code change ### DirectCouponList * Set segment ReadOnly if given flag is ReadOnly. ### DirectHll4Array * fixed a bug, the given readOnly parameter was not passed. ### DirectHll6Array * fixed a bug, the given readOnly parameter was not passed. ### DirectHll8Array * fixed a bug, the given readOnly parameter was not passed. ### DirectHllArray * fixed a bug, the given readOnly parameter was not used. ### HllArray * Added comments to empty blocks. ## hllmap ### Map * Added comments to empty blocks. * Added parentheses for clarity ## kll ### KllDoublesSketch * Removed unnecessary parameter ### KllFloatsSketch * Removed unnecessary parameter ### KllHeapDoublesSketch * Added comments to empty blocks. ### KllHeapFloatsSketch * Added comments to empty blocks. ### KllHeapLongsSketch * Added comments to empty blocks. ### KllHelper * remove unused SerDe ### KllItemsHelper * Added comments to empty blocks. ### KllItemsSketch * remove unused SerDe ### KllLongsSketch * remove unused SerDe ### KllPreambleUtil * remove unused \<T\> qualifier ## (classic) quantiles ### ClassicUtil * Added method to compute growing base buffer size. * package-private static method checkIsMemorySegmentCompact(MemorySegment) was returning true if readOnly flag was set or compact flag was set. Changed it to only return true if compact flag is set. ### CompactDoublesSketch * Added comments to empty blocks. ### DirectCompactDoublesSketch * Clarified comment * Added 2nd parameter to accessor wrap() for clarity ### DirectDoublesSketchAccessor * Changed idxOffset to byteOffset for more clarity * Used MemorySegment.asSlice() where it made sense. * Simple Reformating, no code change ### DirectUpdateDoublesSketch * Refactoring due to removal of DirectUpdateDoublesSketchR ### DoublesBufferAccessor * Added missing Javadoc ### DoublesMergeImpl * Added 2nd parameter for clarity ### DoublesSketch * Cleaned up javadoc * Added MemorySegmentRequest as 2nd parameter to factory wrap() * Changed method name for more clarity. * Improved Javadocs * Added 2nd parameter to accessor wrap() for clarity ### DoublesSketchAccessor * Added and improved Javadocs * Added more code comments ### DoublesSketchIterator * Added 2nd parameter to accessor wrap() for clarity ### DoublesUnion * Improved Javadoc ### DoublesUnionImpl * Refactoring due to removal of DoublesUnionImplR ### DoublesUtil * Changes due to internal API change * Removed unnecessary \<T\> qualifier * minor refactoring ### HeapCompactDoublesSketch * Added 2nd parameter to accessor wrap() for clarity ### HeapDoublesSketchAccessor * Minor variable name changes ### HeapUpdateDoublesSketch * Added code comments * updated growth method to refer to a common util method ### DirectUpdateDoublesSketchR * Removed, not needed in the context of FFM ### DoublesUnionImplR * Removed, not needed in the context of FFM ## req ### ReqCompactor * Added comments to empty blocks. ## theta ### ConcurrentDirectQuickSelectSketch * Added comments to empty blocks. * Added "finals" * Removed trailing spaces ### ConcurrentHeapQuickSelectSketch * Added comments to empty blocks. ### ConcurrentHeapThetaBuffer * Added comments to empty blocks. * Changes due to removing DirectUpdateDoublesSketchR ### DirectQuickSelectSketch * Added SuppressWarnings for dummy, but required, variable ## sampling ### EbppsItemsSketch * Added comments to empty blocks. ## tuple/arrayofdoubles ### DirectArrayOfDoublesQuickSelectSketch * Added "finals" * Added SuppressWarnings for dummy, but required, variable # Test ## (classic) quantiles ### DirectCompactDoublesSketchTest * Add MemorySegmentRequest for modified API ### DirectUpdateDoublesSketchTest * Refactoring due to removal of DirectUpdateDoublesSketchR ### DoublesSketchTest * Added 2nd parameter to accessor wrap() for clarity * Added 2nd parameter to factory wrap() ### DoublesUnionBuilderTest * Changes due to internal API change ### DoublesUnionImplTest * Changes due to internal API change ### DoublesUtilTest * Changes due to internal API change ### HeapUpdateDoublesSketchTest * Added 2nd parameter to accessor wrap() for clarity * Changes due to internal API change * updated diagnostic println methods ### QuantilesSketchCrossLanguageTest * Changes due to internal API change ### ReadOnlyMemoryTest * Changes due to internal API change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
