leerho commented on code in PR #689:
URL: https://github.com/apache/datasketches-java/pull/689#discussion_r2418277524
##########
src/test/java/org/apache/datasketches/theta/HeapAlphaSketchTest.java:
##########
@@ -666,21 +666,21 @@
@Test
public void checkFamily() {
- UpdateSketch sketch = UpdateSketch.builder().setFamily(ALPHA).build();
+ UpdatableThetaSketch sketch =
UpdatableThetaSketch.builder().setFamily(ALPHA).build();
assertEquals(sketch.getFamily(), Family.ALPHA);
}
@SuppressWarnings("unused")
@Test(expectedExceptions = SketchesArgumentException.class)
public void corruptionLgNomLongs() {
final int k = 512;
- UpdateSketch sketch = UpdateSketch.builder().setNominalEntries(k)
+ UpdatableThetaSketch sketch =
UpdatableThetaSketch.builder().setNominalEntries(k)
.setFamily(ALPHA).build();
for (int i = 0; i < k; i++) { sketch.update(i); }
byte[] byteArr = sketch.toByteArray();
MemorySegment wseg = MemorySegment.ofArray(byteArr);
wseg.set(JAVA_BYTE, LG_NOM_LONGS_BYTE, (byte) 8); //corrupt LgNomLongs
- UpdateSketch sk = UpdateSketch.heapify(wseg);
+ UpdatableThetaSketch sk = UpdatableThetaSketch.heapify(wseg);
Review Comment:
This was in Test, so pretty harmless, nonetheless:
Removed unused var & removed unused SuppressWarnings("unused").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
