leerho commented on code in PR #687:
URL: https://github.com/apache/datasketches-java/pull/687#discussion_r2403661167
##########
src/main/java/org/apache/datasketches/hll/TgtHllType.java:
##########
@@ -60,7 +60,7 @@ public enum TgtHllType {
*/
HLL_6,
/**
- * An Hll Sketch with a bin size of 8 bits
Review Comment:
Really? The HyperLogLog abbreviation appears in multiple cases both in code
and comments: hll, Hll, HLL. And, yes, this could have been spelled all caps
as HLL, but I don't think that it should cause any confusion.
I appreciate your wanting to make a contribution, thank you, but it would be
even more appreciated if you could find more substantive areas where improved
comments would add clarity, and I am sure there are many :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
