Fengzdadi commented on issue #103: URL: https://github.com/apache/datasketches-go/issues/103#issuecomment-3765571515
Thank you for your kindness! Both of your understandings are correct: 1. **Missing features** - Yes, some features were missing compared to Java 2. **Misimplementation** - Yes, there were issues in the merge logic I have already completed the fixes for both issues: 1. Fixed `twoWayMergeInternal` logic 2. Added `DownsampledCopy`, `Copy`, and other missing methods 3. Implemented serialization (`ToSlice` / `NewReservoirItemsUnionFromSlice`) 4. Added comprehensive tests (17 test cases covering all scenarios). Here, the Go implementation only supports Serialization Version 2 (the current format). I will submit the PR shortly after double-checking the code logic. > I will add cross language test cases for union case. Thank you! I think that adding cross-language compatibility tests for `ReservoirItemsUnion` would be very helpful for ensuring binary compatibility across languages. Thank you again for your patient guidance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
