tisonkun commented on code in PR #71: URL: https://github.com/apache/datasketches-rust/pull/71#discussion_r2731044677
########## datasketches/src/countmin/mod.rs: ########## @@ -34,12 +34,16 @@ //! //! ```rust //! # use datasketches::countmin::CountMinSketch; -//! let buckets = CountMinSketch::suggest_num_buckets(0.01); -//! let hashes = CountMinSketch::suggest_num_hashes(0.99); -//! let _sketch = CountMinSketch::new(hashes, buckets); +//! let buckets = CountMinSketch::<i64>::suggest_num_buckets(0.01); +//! let hashes = CountMinSketch::<i64>::suggest_num_hashes(0.99); +//! let _sketch = CountMinSketch::<i64>::new(hashes, buckets); //! ``` mod serialization; mod sketch; pub use self::sketch::CountMinSketch; + +mod value; +pub use self::value::CountMinValue; +pub use self::value::UnsignedCountMinValue; Review Comment: Sealed not to be impl. But make them `pub` would help in documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
