tisonkun commented on code in PR #84:
URL: https://github.com/apache/datasketches-rust/pull/84#discussion_r2764754983
##########
datasketches/src/cpc/pair_table.rs:
##########
@@ -64,17 +64,13 @@ impl PairTable {
// sorted pairs array. However, we are starting out with the correct
final table size, so
// the problem might not occur.
- for slot in slots {
- table.must_insert(slot);
+ for i in 0..num_items {
Review Comment:
I suppose the following slice index access would provide necessary bound
check and panic better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
