> But I suspect if users want to check snapshot tests, it will fail? No. If snapshot files are not present, then the test will be skipped. I've checked all missing snapshots cases, but if you notice any test still failing please point me to it. If users have valid snapshot tests, it will succeed.
On Sat, Feb 7, 2026 at 11:54 PM Zili Chen <[email protected]> wrote: > +1 binding > > I checked: > > + Download links valid > + Signature matched > > apache-datasketches-go-0.1.0-src.tar.gz > gpg: Signature made Wed Feb 4 22:39:17 2026 CST > gpg: using RSA key C614A2E649BB45F7FF7F849719272095A6D67D98 > gpg: Good signature from "HyeonhoKim (CODE SIGNIN KEY) <[email protected]>" > [unknown] > gpg: WARNING: This key is not certified with a trusted signature! > gpg: There is no indication that the signature belongs to the > owner. > Primary key fingerprint: C614 A2E6 49BB 45F7 FF7F 8497 1927 2095 A6D6 7D98 > > + Checksum valid > + NOTICE file exists. The year can be updated later. > + LICENSE file exists. > + All files has ASF license header > + No unexpected binary files (all snapshot files are excluded) > + Can go build ./... from source > > But I suspect if users want to check snapshot tests, it will fail? > > On 2026/02/04 15:04:00 Hyeonho Kim wrote: > > Hi everyone! > > > > I would like to propose releasing Apache DataSketches Go v0.1.0. > > Changes since RC3: > > - Fixed artifact packaging issue > > - Fixed several flaky test cases > > > > Source Distribution: > > https://dist.apache.org/repos/dist/dev/datasketches/go/0.1.0-RC4/ > > > > Github tag: > > https://github.com/apache/datasketches-go/releases/tag/v0.1.0-rc4 > > > > How to use (choose one or both): > > > > - Go module: > > > > go get github.com/apache/[email protected] > > > > - From source: > > > > Download, verify signatures, and run tests. > > > > > > To verify signatures: > > > > curl -O > > > https://dist.apache.org/repos/dist/dev/datasketches/go/0.1.0-RC4/apache-datasketches-go-0.1.0-src.tar.gz > > > > curl -O > > > https://dist.apache.org/repos/dist/dev/datasketches/go/0.1.0-RC4/apache-datasketches-go-0.1.0-src.tar.gz.asc > > > > gpg --verify apache-datasketches-go-0.1.0-src.tar.gz.asc > > > > > > To run tests (choose one or both): > > > > - If you have already installed go: > > > > go test ./... > > > > - If you have container runtime(e.g., Docker): > > > > ./build/run-docker-test.sh > > > > > > The vote will remain open for at least 72 hours. > > > > [ ] +1 Release this as Apache DataSketches Go 0.1.0 > > [ ] 0 No opinion > > [ ] -1 Do not release (please explain why) > > > > Best regards, > > Hyeonho Kim > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
