ZENOTME commented on PR #85: URL: https://github.com/apache/datasketches-rust/pull/85#issuecomment-3866878705
> 1. Shall we check the seed when creating sketches? Currently, we check only when serde, thus if the sketch never serde, we don't have this guard. Not sure if check earilier helps. I think we should check the seed when creating sketches. I think it's not convenient to change the seek after using the sketch, so it's better to guarantee that the seed hash is valid at begining. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
