tisonkun commented on code in PR #77:
URL: https://github.com/apache/datasketches-rust/pull/77#discussion_r2808624675
##########
datasketches/src/frequencies/sketch.rs:
##########
@@ -488,7 +488,7 @@ impl<T: Eq + Hash> FrequentItemsSketch<T> {
if pre_longs != PREAMBLE_LONGS_NONEMPTY {
return Err(Error::invalid_preamble_longs(
- PREAMBLE_LONGS_NONEMPTY,
+ std::slice::from_ref(&PREAMBLE_LONGS_NONEMPTY),
Review Comment:
Pushed a new commit to fine tune codec assertions.
I'm feeling several code are generated by AI without carefully review.
@ZENOTME please review your own patch again to avoid some obvious dirty code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
