Hello, Gentle reminder that this vote (DataSketches Go release v0.1.0) has been open for more than 10 days, it got two +1 binding votes (missing at least one) to conclude this vote successfully.
Thanks ! On Tue, Feb 3, 2026 at 3:22 PM Hyeonho Kim <[email protected]> wrote: > > Thank you! > > Sorry, I missed that point. I will check the whole sketch and prepare again. > > On Tue, Feb 3, 2026 at 3:42 AM Pierre Lacave <[email protected]> wrote: >> >> -1 (binding) >> >> GPG and SHA signatures are ok >> License are OK >> >> However tests are failing, because as we are not shipping the sk files >> in the archives we have to guard the test with a presence check to >> avoid skip if the files are missing >> (the other sketches skip with a warn iirc) >> >> I ll push a fix now >> >> ❯ tar -xzf apache-datasketches-go-0.1.0-src.tar.gz >> cd apache-datasketches-go-0.1.0 >> go test ./... >> ? github.com/apache/datasketches-go [no test files] >> ? github.com/apache/datasketches-go/common [no test files] >> ok github.com/apache/datasketches-go/count 0.561s >> ok github.com/apache/datasketches-go/cpc 4.843s >> ok github.com/apache/datasketches-go/examples 1.000s >> ok github.com/apache/datasketches-go/filters 1.159s >> ok github.com/apache/datasketches-go/frequencies 1.358s >> ok github.com/apache/datasketches-go/hll 4.794s >> ok github.com/apache/datasketches-go/internal 1.760s >> ok github.com/apache/datasketches-go/internal/binomialbounds 2.156s >> ok github.com/apache/datasketches-go/internal/binomialproportionsbounds >> 1.926s >> ok github.com/apache/datasketches-go/kll 3.047s >> --- FAIL: TestSerializationCompatibilityEmpty (0.00s) >> compatibility_test.go:255: >> Error Trace: >> /Users/pierre.lacave/Documents/apache-datasketches-go-0.1.0/sampling/compatibility_test.go:255 >> Error: Received unexpected error: >> open >> ../serialization_test_data/go_generated_files/reservoir_items_long_empty_k128_go.sk: >> no such file or directory >> Test: TestSerializationCompatibilityEmpty >> compatibility_test.go:258: >> Error Trace: >> /Users/pierre.lacave/Documents/apache-datasketches-go-0.1.0/sampling/compatibility_test.go:258 >> Error: Received unexpected error: >> data too short >> Test: TestSerializationCompatibilityEmpty >> panic: runtime error: invalid memory address or nil pointer >> dereference [recovered, repanicked] >> [signal SIGSEGV: segmentation violation code=0x2 addr=0x8 pc=0x100933f40] >> >> goroutine 8 [running]: >> testing.tRunner.func1.2({0x1009feb80, 0x100be1070}) >> /opt/homebrew/Cellar/go/1.25.4/libexec/src/testing/testing.go:1872 +0x190 >> testing.tRunner.func1() >> /opt/homebrew/Cellar/go/1.25.4/libexec/src/testing/testing.go:1875 +0x31c >> panic({0x1009feb80?, 0x100be1070?}) >> /opt/homebrew/Cellar/go/1.25.4/libexec/src/runtime/panic.go:783 +0x120 >> github.com/apache/datasketches-go/sampling.(*ReservoirItemsSketch[...]).IsEmpty(...) >> /Users/pierre.lacave/Documents/apache-datasketches-go-0.1.0/sampling/reservoir_items_sketch.go:156 >> github.com/apache/datasketches-go/sampling.TestSerializationCompatibilityEmpty(0x140000e2000) >> /Users/pierre.lacave/Documents/apache-datasketches-go-0.1.0/sampling/compatibility_test.go:259 >> +0xe0 >> testing.tRunner(0x140000e2000, 0x100a42838) >> /opt/homebrew/Cellar/go/1.25.4/libexec/src/testing/testing.go:1934 +0xc8 >> created by testing.(*T).Run in goroutine 1 >> /opt/homebrew/Cellar/go/1.25.4/libexec/src/testing/testing.go:1997 +0x364 >> FAIL github.com/apache/datasketches-go/sampling 1.633s >> ok github.com/apache/datasketches-go/tdigest 1.527s >> ok github.com/apache/datasketches-go/theta 5.626s >> ok github.com/apache/datasketches-go/tuple 1.538s >> FAIL >> >> On Mon, Feb 2, 2026 at 4:48 PM Hyeonho Kim <[email protected]> wrote: >> > >> > Hi everyone! >> > >> > I would like to propose releasing Apache DataSketches Go v0.1.0. >> > >> > Source Distribution: >> > https://dist.apache.org/repos/dist/dev/datasketches/go/0.1.0-RC3/ >> > >> > Github tag: >> > https://github.com/apache/datasketches-go/releases/tag/v0.1.0-rc3 >> > >> > How to use (choose one or both): >> > >> > - Go module: >> > >> > go get github.com/apache/[email protected] >> > >> > - From source: >> > >> > Download, verify signatures, and run tests. >> > >> > >> > To verify signatures: >> > >> > curl -O >> > https://dist.apache.org/repos/dist/dev/datasketches/go/0.1.0-RC3/apache-datasketches-go-0.1.0-src.tar.gz >> > >> > curl -O >> > https://dist.apache.org/repos/dist/dev/datasketches/go/0.1.0-RC3/apache-datasketches-go-0.1.0-src.tar.gz.asc >> > >> > gpg --verify apache-datasketches-go-0.1.0-src.tar.gz.asc >> > >> > >> > To run test (choose one or both): >> > >> > - If you have already installed go: >> > >> > go test ./... >> > >> > - If not, but if you have container runtime like docker: >> > >> > ./build/run-docker-test.sh >> > >> > >> > Vote will remain open for at least 72 hours. >> > >> > [ ] +1 Release this as Apache DataSketches Go 0.1.0 >> > [ ] 0 No opinion >> > [ ] -1 Do not release (please explain why) >> > >> > Best regards, >> > Hyeonho Kim >> > >> > >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
