tisonkun commented on code in PR #100:
URL: https://github.com/apache/datasketches-rust/pull/100#discussion_r2832828860
##########
datasketches/src/theta/hash_table.rs:
##########
@@ -302,6 +343,55 @@ impl ThetaHashTable {
compute_seed_hash(self.hash_seed)
}
+ /// Returns true if the given hash exists in the table.
+ #[allow(dead_code)]
+ pub fn contains_hash(&self, hash: u64) -> bool {
Review Comment:
Why allow dead_code?
I'd prefer to add private methods with their usage instead of pre-inject
logics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
