leerho commented on code in PR #155: URL: https://github.com/apache/datasketches-rust/pull/155#discussion_r3654603784
########## datasketches/src/theta/a_not_b.rs: ########## Review Comment: @tisonkun, You are correct, a_not_b is not symmetric, because the math operation it emulates is not symmetric. Yes, and the CamelCase is not perfect. But other languages are free to spell the function differently if they like. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
