hawkingrei commented on PR #142: URL: https://github.com/apache/datasketches-rust/pull/142#issuecomment-5151129742
Updated the branch onto current `main` (head: `419be13`). The Jaccard implementation now follows the same shape as the C++ `jaccard_similarity_base`: - it composes the existing shared `UnionState` and `IntersectionState` rather than keeping a separate set-operation implementation; - the common raw layer is generic over `ThetaFamilySketchView`, so Tuple can reuse it when its Jaccard API is added; - tests moved into the current `theta_test` layout and now assert an accurate estimate plus ordered confidence bounds. Validated locally with `cargo test -p datasketches --features theta --test theta_test` and `cargo clippy -p datasketches --features theta --test theta_test -- -D warnings`. The all-feature serialization suite requires the generated Java/Go/C++ fixture set (`cargo x prepare-testdata`), which is not present locally. Could you please take another look at the updated API and shared-operation structure? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
