leerho opened a new issue, #4: URL: https://github.com/apache/datasketches-tck/issues/4
I'm in the process of updating Java to execute the Go generated *.sk images. And I stumbled on this: JAVA_GENERATED_FILES bf_n0_h3_java.sk bf_n0_h5_java.sk bf_n10000_h3_java.sk bf_n10000_h5_java.sk bf_n2000000_h3_java.sk bf_n2000000_h5_java.sk bf_n30000000_h3_java.sk bf_n30000000_h5_java.sk CPP_GENERATED_FILES bf_n0_h3_cpp.sk bf_n0_h5_cpp.sk bf_n10000_h3_cpp.sk bf_n10000_h5_cpp.sk bf_n2000000_h3_cpp.sk bf_n2000000_h5_cpp.sk bf_n30000000_h3_cpp.sk bf_n30000000_h5_cpp.sk GO_GENERATED_FILES bf_n0_h3_go.sk bf_n0_h5_go.sk bf_n10000_h3_go.sk bf_n10000_h5_go.sk bf_n2000000_h3_go.sk bf_n2000000_h5_go.sk PLUS long, double, byte[], string variants GO has generated a number of other variants which is great, but the basic set is missing the two images where n = 30E6. Perhaps this is just an oversight. If we can keep some minimum set of values for each relevant parameter it makes adding additional languages almost trivial. All I had to do for GO is copy my test for the CPP files and just change the path and the file name to end with "*_go.sk". Voila! But in this particular case it had missing files then I had to dig to find out why. Adding extra tests beyond the minimum set is wonderful, and eventually the earlier languages will catch up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
