tisonkun commented on code in PR #204:
URL: https://github.com/apache/datasketches-rust/pull/204#discussion_r3814737183
##########
datasketches/src/codec/family.rs:
##########
@@ -80,6 +80,15 @@ impl Family {
max_pre_longs: 5,
};
+ /// Relative Error Quantiles (REQ) sketch.
+ #[cfg(feature = "req")]
+ pub const REQ: Family = Family {
+ id: 17,
+ name: "REQ",
+ min_pre_longs: 2,
+ max_pre_longs: 4,
Review Comment:
From datasketches-java, these fields are:
```java
REQ(17, "REQ", 1 /* minPreLongs */, 2 /* maxPreLongs */),
```
But we don't use these fields for REQSketch anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
