tisonkun commented on code in PR #76:
URL: https://github.com/apache/datasketches-rust/pull/76#discussion_r3818996719
##########
datasketches/src/codec/family.rs:
##########
@@ -71,6 +71,15 @@ impl Family {
max_pre_longs: 4,
};
+ /// KLL sketch for estimating quantiles and ranks.
+ #[cfg(feature = "kll")]
+ pub const KLL: Family = Family {
+ id: 15,
+ name: "KLL",
+ min_pre_longs: 1,
+ max_pre_longs: 3,
+ };
Review Comment:
datasketches-java has:
```java
Family.KLL(15, "KLL", 1, 2)
```
that means `max_pre_longs = 2`.
May I ask where `max_pre_longs: 3` comes from?
cc @PsiACE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
