tisonkun opened a new pull request, #215:
URL: https://github.com/apache/datasketches-rust/pull/215

   ## Summary
   
   - upgrade the workspace `rand` requirement from 0.9.2 to 0.10.0; the 
lockfile resolves the latest compatible release, 0.10.2
   - keep the REQ compactor coin flip unchanged because `rand::random` remains 
source-compatible
   - retain proptest for the existing REQ property tests after comparing it 
with quickcheck
   
   ## Property-testing choice
   
   The existing REQ properties use explicit numeric ranges and 
collection-length ranges. Proptest strategies express those constraints 
directly and preserve them while shrinking, which matches these tests better 
than QuickCheck's type-oriented `Arbitrary` model. See the [official proptest 
comparison](https://proptest-rs.github.io/proptest/proptest/vs-quickcheck.html).
   
   QuickCheck 1.1 already depends on rand 0.10, but changing frameworks only to 
deduplicate a test dependency would require custom generators or wrapper types 
and would make the tests less direct. Proptest 1.11 still depends on rand 0.9; 
its unreleased branch has already migrated to rand 0.10 according to the 
[upstream 
changelog](https://github.com/proptest-rs/proptest/blob/main/proptest/CHANGELOG.md).
 This PR therefore waits for a released proptest update instead of pinning an 
unreleased Git revision.
   
   The resulting dependency split is intentional and temporary:
   
   - the datasketches library uses rand 0.10.2
   - proptest uses rand 0.9.5 only in the development/test graph
   
   No changelog entry is included because this is dependency maintenance 
without a supported or observable behavior change.
   
   ## Validation
   
   - `cargo test --locked -p datasketches --features req --test req_test`
   - `cargo x check`
   - `cargo x test`
   - `cargo x lint`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to