I get some errors on the modular branch; they need to be addressed
before we can commit this patch series.
(1) Running 'rake test' gives me
/homes/lutter/.gem/ruby/1.8/gems/rake-0.9.2.2/lib/rake/ext/module.rb:36:in
`const_missing': uninitialized constant
Deltacloud::Helpers::Application::API_ROOT_URL (NameError)
(2) Trying to upload a blob through the HTML UI gives me
/homes/lutter/code/deltacloud/git/server/lib/deltacloud/./helpers/blob_stream_helper.rb:191:in
`is_put_blob': undefined local variable or method `settings' for
BlobStreamIO:Class (NameError)
(3) minitest isn't mentioned in the Gemfile
(4) running 'rake test:api' gives me
test_0007_must_have_some_key_elements_inside_keys_(Deltacloud API Keys)
[/homes/lutter/code/deltacloud/git/server/tests/drivers/api/keys_test.rb:43]:
Expected [] to not be empty.
(5) Running 'rake features' in tests/ gives me
Error creating formatter: html (Errno::ENOENT)
/homes/lutter/.gem/ruby/1.8/gems/cucumber-1.1.4/bin/../lib/cucumber/formatter/io.rb:7:in
`initialize'
To commit these, we need to get to a state where all the tests pass;
that's the biggest blocker right now.
Also, to make the patch series a little less daunting, you might
consider splitting patches that aren't directly related to modularizing
DC out (e.g., 14/32 or 30-32/32) This will make it much easier to review
them and get them committed separately.
David
