On Wed, 2012-12-12 at 09:24 -0500, jvlcek wrote: > On 12/11/2012 07:05 PM, David Lutterkort wrote: > > On Tue, 2012-12-11 at 17:27 -0500, [email protected] wrote: > >> DTACLOUD-379 using Marios's 409 solution. > >> > > Thank you David, > > > ACK to this; stylistically, the two patches should be squashed into one, > > since after applying 1/2 triggering this error will cause a server error > > because of a missing template. > > My intention was to clearly show credit to Marios for the work he had done. > Collapsing the patches into one would have made it appear that the > entire solution was only my doing. That said I fully agree with your > point about the one patch alone leading to issues.
Wanting to give credit is very good - but as a rule of thumb, bisectability beats credit ;) IOW, we want to make sure that all tests can run through successfully after each patch. David
