Hi Marios,

some comments:

On Tue, 2012-12-18 at 19:26 +0200, [email protected] wrote:
> diff --git a/server/lib/cimi/collections/machines.rb 
> b/server/lib/cimi/collections/machines.rb
> index b18fb1c..e5e1836 100644
> --- a/server/lib/cimi/collections/machines.rb
> +++ b/server/lib/cimi/collections/machines.rb
> @@ -16,7 +16,10 @@
>  module CIMI::Collections
>    class Machines < Base
>  
> +    include CIMI::Features

Shouldn't this go into CIMI::Collections::Base ? We don't want to have
to repeat that for every entity that exposes capabilities.

> diff --git a/server/lib/cimi/collections/volume_templates.rb 
> b/server/lib/cimi/collections/volume_templates.rb
> new file mode 100644
> index 0000000..c73934e
> --- /dev/null
> +++ b/server/lib/cimi/collections/volume_templates.rb

I'll just repeat my grumbly point that this should go into a different
patch, since it doesn't have anything to do with capabilities.

> diff --git a/server/lib/cimi/models/volume_template.rb 
> b/server/lib/cimi/models/volume_template.rb
> index b2ac323..bb632c6 100644
> --- a/server/lib/cimi/models/volume_template.rb
> +++ b/server/lib/cimi/models/volume_template.rb
> @@ -22,4 +22,7 @@ class CIMI::Model::VolumeTemplate < CIMI::Model::Base
>    array :operations do
>      scalar :rel, :href
>    end
> +
> +  def self.find(id, context)
> +  end

As Ronelle noticed, this will just make retrieving volume templates blow
up.

David


Reply via email to