On Wed, 2013-01-23 at 16:51 +0100, [email protected] wrote:
> From: Michal Fojtik <[email protected]>
>
>
> Signed-off-by: Michal fojtik <[email protected]>
NACK because there is no test that verifies that JIRA 433 is indeed
fixed. Other than that, the patch looks fine with one small nit:
> diff --git a/server/lib/cimi/models/base.rb b/server/lib/cimi/models/base.rb
> index 1393ae4..7995e07 100644
> --- a/server/lib/cimi/models/base.rb
> +++ b/server/lib/cimi/models/base.rb
> @@ -185,12 +185,20 @@ class CIMI::Model::Resource
> def initialize(values = {})
> names = self.class.schema.attribute_names
> @filter_attrs = values[:filter_attr_list] || []
> + # Make sure we always have the :id of the entity even
> + # the $select parameter is used and :id is filtered out
> + #
> + @_base_id = values[:base_id] || values[:id]
Why is this called @_base_id rather than @base_id ?
David
