[ 
https://issues.apache.org/jira/browse/DTACLOUD-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564175#comment-13564175
 ] 

Marios Andreou commented on DTACLOUD-441:
-----------------------------------------

[ Adding IRC context ]:   tl;dr - Dies can you make the patch being mindful of 
what we said below. I can test it on those providers for which you don't have 
creds.

(12:02:00) marios: dkoper: my main concern is to keep those tests driver 
agnostic
(12:02:07) dkoper: I thought on irc I mentioned cleanup didn't call destroy, 
you pointed to the line that did "stop" and I thought we didn't finish that 
conversation.
(12:02:19) marios: dkoper: i.e. 'should work' for any driver, fgcp, ec2, mock 
etc
(12:02:51) dkoper: yes. my worry is that I can test fgcp and mock, and that's 
about it. Unless you can give me access to other clouds.
(12:02:56) marios: dkoper: so just do it cleanly - like if you do call 
'stop'/'destroy' whatever, make sure you catch error (e..g. you call stop for 
an instance... for driver foo this makes the instance go away, so when you call 
destroy you'd bget e.g. a 404)
(12:03:23) marios: dkoper: perhaps a jira issue is best to track this and keep 
this conversation in one place.
(12:03:38) marios: dkoper: next week - i/you may not remember what we said here.
(12:03:41) dkoper: I have an ec2 account but last time I tried to access it 
through DC (9 months ago), it failed. I thought because the ec2 gem didn't 
support http proxies.
(12:03:55) marios: dkoper: why don't you file a jira, make a patch attach it 
there and we take it from there
                
> api tests don't clean up after themselves
> -----------------------------------------
>
>                 Key: DTACLOUD-441
>                 URL: https://issues.apache.org/jira/browse/DTACLOUD-441
>             Project: DeltaCloud
>          Issue Type: Test
>          Components: Server
>         Environment: Fgcp driver
>            Reporter: Dies Koper
>            Assignee: Dies Koper
>            Priority: Minor
>
> When running DC api tests (rake tests:deltacloud in root tests folder), the 
> following is logged at the end (when using with Fgcp):
> CLEANING UP... resources for deletion: {:firewalls=>[], 
> :instances=>["UZXC0GRT-ZG8ZJCJ07-S-0113"], :keys=>[], :images=>[]}
> CLEANUP attempt finished... resources looks like: 
> {:instances=>["UZXC0GRT-ZG8ZJCJ07-S-0113"]}
> deltacloud/instances_test.rb:71: Unable to delete all created resources - 
> please check: {:instances=>["UZXC0GRT-ZG8ZJCJ07-S-0113"]} (Ex
> ception)
>         from deltacloud/instances_test.rb:244:in `call'
>         from deltacloud/instances_test.rb:244:in `to_proc'
>         from 
> D:/programs/Ruby187/lib/ruby/gems/1.8/gems/minitest-4.4.0/lib/minitest/unit.rb:782:in
>  `reverse_each'
>         from 
> D:/programs/Ruby187/lib/ruby/gems/1.8/gems/minitest-4.4.0/lib/minitest/unit.rb:782:in
>  `autorun'
> The reason it failed to delete them is because it only tried to stop them, 
> not destroy them. For Fgcp, stopping an instance doesn't destroy it.
> Suggesting to add code that calls the destroy_instance operation on instances 
> after the stop operation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to