On 03/07/2013 05:57 PM, [email protected] wrote: > These patches change things so that the RHEV-M tests do not depend on any > hardcoded values. Rather, everything is now read from > ~/.deltacloud/config. The new entries for rhevm in that file should be: > > rhevm: > user: USERNAME > password: PASSWORD > provider: https://rhevm.example.com/api > preferred: > datacenter: UUID of a datacenter/realm > vm: UUID of an existing instance > template: UUID of an existing template > > It's now also possible to rerecord tests by setting the env var > VCR_RECORD=all > > Patch 6/6 is too large to send out; I have recorded the series as > http://tracker.deltacloud.org/set/380 The last patch is available as > http://tracker.deltacloud.org/patch/1a3d36c3 > > Joe: can you update the site docs about rerecording to reflect these > changes ? > > David
nack and 2 nits nack because the ec2 gogrid and rhevm driver tests fail with this patch applied. See attached file: failing_tests The 2 nits. 1 - using admin:secret for the creds might match live creds. Would it be safer to use something far less likely to possibly match e.g.: fakeuser:fakepassword 2 - Patch 5/6 defines 2 new methods but I don't see where they are being used. Am I missing something? I'm totally OK with you pushing this with these 2 nits but the test failure are an issue.. Joe
% rake test:drivers:ec2 /exports/bos/jvlcek/GIT/DELTACLOUD_OVIRT/deltacloud/server/tests/test_helper.rb:84: stack level too deep (SystemStackError) rake aborted! Command failed with status (1): [ruby -I"lib" -S testrb "tests/drivers/ec2/buckets_test.rb" "tests/drivers/ec2/images_test.rb" "tests/drivers/ec2/instance_test.rb" "tests/drivers/ec2/keys_test.rb" "tests/drivers/ec2/realms_test.rb" "tests/drivers/ec2/storage_snapshots_test.rb" ] Tasks: TOP => test:drivers:ec2 (See full trace by running task with --trace) % rake test:drivers:gogrid /exports/bos/jvlcek/GIT/DELTACLOUD_OVIRT/deltacloud/server/tests/test_helper.rb:84: stack level too deep (SystemStackError) rake aborted! Command failed with status (1): [ruby -I"lib" -S testrb "tests/drivers/gogrid/hardware_profiles_test.rb" "tests/drivers/gogrid/images_test.rb" "tests/drivers/gogrid/instances_test.rb" "tests/drivers/gogrid/realms_test.rb" ] Tasks: TOP => test:drivers:gogrid (See full trace by running task with --trace) % rake test:drivers:rhevm /exports/bos/jvlcek/GIT/DELTACLOUD_OVIRT/deltacloud/server/tests/test_helper.rb:84: stack level too deep (SystemStackError) rake aborted! Command failed with status (1): [ruby -I"lib" -S testrb "tests/drivers/rhevm/images_test.rb" "tests/drivers/rhevm/instance_test.rb" "tests/drivers/rhevm/provider_test.rb" "tests/drivers/rhevm/realms_test.rb" ] Tasks: TOP => test:drivers:rhevm (See full trace by running task with --trace)
