On 03/21/2013 06:42 PM, Joseph VLcek wrote:
Michal,
This looks great. Many of my comments are really questions regarding
why you used Ruby the way you did.
I've formated my feedback/questions in the attached patch.
I think you forgot to attach the patch (or my thunderbird is crazy ;)
I had initially started making code changes but then decided to
just leave comments/questions in the code, prefaced wtih "Joe".
Thanks! I'll look at it and will try to respond by mail.
I've also done some tpyo and grammar fixes and comment changes to
attempt to make the comments more consistent.
A general question: Are we trying to stick to 80char line lenght?
I'm trying to :-) It is not possible all the time, but where it is
possible I try to stick to 80 chars. It makes code/patches more readable.
-- Michal
Hope this helps!
Joe V.
--
Michal Fojtik <[email protected]>
Deltacloud API, CloudForms
