I absolutely agree, no problem!
I had added classes to produce the problem, but astonishingly failed.
There is definitely a difference between Weld5 standalone and
Wildfly-DeploymentScanner-deployment,
but I was not able to track this down :-/
Am Mo., 19. Feb. 2024 um 14:36 Uhr schrieb Thomas Andraschko <
andraschko.tho...@gmail.com>:
> I would suggest the following:
>
> 1) we revert your PR
> 2) you add your testcase in a new PR and you try to fail our Weld CI build
> 3) when it fails, we can debug together and work on a fix
>
> Am Mo., 19. Feb. 2024 um 14:32 Uhr schrieb Thomas Frühbeck <
> t.fruehb...@gmail.com>:
>
> > the intermediate Repository class:
> >
> > *// no annotation present!!*
> >
> > public abstract class AbstractElementRepository<E extends Element, PK
> > extends Serializable> extends AbstractFullEntityRepository<E, PK>
> > implements
> > ElementRelated {
> >
> >
> > in RepsitoryExtension: for the intermediate AbstractElementRepository
> class
> > (no Annotation!!!) Weld will find:
> > event.getAnnotatedType().getJavaClass(): class
> > at.telekom.archive.repository.AbstractElementRepository
> > and:
> >
> >
> event.getAnnotatedType().getJavaClass().isAnnotationPresent(Repository.class)
> > == true
> >
> > Help very much appreciated, else application broken!!!
> >
> >
> > Am Mo., 19. Feb. 2024 um 14:07 Uhr schrieb tandraschko (via GitHub) <
> > g...@apache.org>:
> >
> > >
> > > tandraschko commented on code in PR #147:
> > > URL:
> > https://github.com/apache/deltaspike/pull/147#discussion_r1494524740
> > >
> > >
> > > ##########
> > >
> > >
> >
> deltaspike/modules/data/impl/src/main/java/org/apache/deltaspike/data/impl/RepositoryExtension.java:
> > > ##########
> > > @@ -90,6 +90,11 @@ else if (isRepository(event.getAnnotatedType()))
> > > LOG.log(Level.FINER, "Class {0} is Deactivated",
> > > repositoryClass);
> > > return;
> > > }
> > > + if
> (repositoryClass.getDeclaredAnnotation(Repository.class)
> > > == null)
> > >
> > > Review Comment:
> > > the outer if should already exact do this code
> > >
> > >
> > >
> > > ##########
> > >
> > >
> >
> deltaspike/modules/data/impl/src/main/java/org/apache/deltaspike/data/impl/RepositoryExtension.java:
> > > ##########
> > > @@ -90,6 +90,11 @@ else if (isRepository(event.getAnnotatedType()))
> > > LOG.log(Level.FINER, "Class {0} is Deactivated",
> > > repositoryClass);
> > > return;
> > > }
> > > + if
> (repositoryClass.getDeclaredAnnotation(Repository.class)
> > > == null)
> > >
> > > Review Comment:
> > > the outer if should already exact do this check in #isRepository
> > >
> > >
> > >
> > > --
> > > This is an automated message from the Apache Git Service.
> > > To respond to the message, please log on to GitHub and use the
> > > URL above to go to the specific comment.
> > >
> > > To unsubscribe, e-mail: dev-unsubscr...@deltaspike.apache.org
> > >
> > > For queries about this service, please contact Infrastructure at:
> > > us...@infra.apache.org
> > >
> > >
> >
>
