cmunier commented on code in PR #160:
URL: https://github.com/apache/deltaspike/pull/160#discussion_r1600498878


##########
deltaspike/modules/jsf/pom.xml:
##########
@@ -39,6 +39,62 @@
         <module>impl</module>
     </modules>
 
+    <build>

Review Comment:
   Hi @tandraschko,
   I just removed the changes to the POMs in `parent` and `modules/jsf`.
   
   If anyone likes the idea of enforcing those consistency rules, the proposed 
changes are still available in 
https://github.com/cmunier/deltaspike/tree/DELTASPIKE-1473-enforce-consistency.
   
   I have had a good experience with using both enforced scopes and especially 
"dependency analyze" in several projects, as it is a measure that is low-effort 
and can be used selectively in part of a multi-module project.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@deltaspike.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to