KlemenDanfoss opened a new issue, #5897:
URL: https://github.com/apache/incubator-devlake/issues/5897

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### What happened
   
   I opened 'DORA Validation dashboard' and there's an issue at retrieving 
graph 'Step 3. Check if a `pull request` is associated with the correct 
`depoloyment commit` in table project_pr_metrics'.
   
   I tried to manually execute the first part of mysql:
   
   ```
        SELECT
                ppm.id AS pr_id,
                ppm.deployment_commit_id AS id_1,
                pr.merge_commit_sha,
                ppm.project_name 
        FROM
                project_pr_metrics ppm
                LEFT JOIN pull_requests pr ON ppm.id = pr.id 
   ```
   
   This is what I get:
   ```
   
+-------------------------------------+--------------------------------------------------------------------------------+------------------------------------------+--------------+
   | pr_id                               | id_1                                 
                                          | merge_commit_sha                    
     | project_name |
   
+-------------------------------------+--------------------------------------------------------------------------------+------------------------------------------+--------------+
   | azuredevops:GitPullRequest:1:191898 |                                      
                                          | 
004f9da27f875cade1767f91ce640886f5941f35 | LH_Monitor   |
   ```
   
   You can clearly see that the id_1 is empty.
   
   In Grafana 'pr_id' is queried with:
   ```
   select concat(Url, '--', id) from pull_requests
   ```
   
   and the URL is retrieved as:
   ```
   select concat(Url, '--', id) from pull_requests
   ```
   
https://dev.azure.com/danfoss/<id>/_apis/git/repositories/<id>/pullRequests/191898
   ```
   
   This also means that 'ppm.id' and 'pd_id' will never match:
   ```
        WHERE
                ppm.project_name in ($project) 
                AND ppm.id = '$pr_id'
   ```
   
   What am I doing wrong?
   
   ### What do you expect to happen
   
   Panel in Grafana dashboard should be populated
   
   ### How to reproduce
   
   Install devlake 0.17, upgrade to 0.18, connect to Azure Devops, ... nothing 
non-standard.
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   v0.18-beta5
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to