Startrekzky commented on issue #7193: URL: https://github.com/apache/incubator-devlake/issues/7193#issuecomment-2066959305
> I thought that might be avoidable - in my case the deployment webhook is still being told which commits are associated and those commits can be associated to the pr they went through etc. @wouldd I don't think it's entirely avoidable, but I agree that your proposal could get the first deployment connected to one of the PRs merged between the first deployment and its prior deployment. We link deployments to pr via the medium 'newly-added-commits-by-d1', but we don't know all of these commits, we only know the merge commit sha and find the PR that is connected to the merge commit sha. Hence, if your use case is to trigger a deployment every time a PR gets merged, it will work. However, not all users use this practice. For those who do not, d1 will only be linked to part of the PRs, and this is the cons I said. I hope it makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
